Skip to content

gh-100305: Deemphasize that ast.literal_eval is safe in eval documentation - #100326

Merged
gpshead merged 6 commits into
python:mainfrom
ramvikrams:t12
Apr 12, 2026
Merged

gh-100305: Deemphasize that ast.literal_eval is safe in eval documentation#100326
gpshead merged 6 commits into
python:mainfrom
ramvikrams:t12

Conversation

@ramvikrams

@ramvikramsramvikrams commented Dec 17, 2022

Copy link
Copy Markdown
Contributor

gh-100305: Changed the doc referencing to literal_eval in eval as it was misleading as literal_eval was said safe

@bedevere-botbedevere-bot mentioned this pull request Dec 17, 2022
Closed
@bedevere-botbedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Dec 17, 2022
slateny
slateny reviewed Dec 20, 2022
View reviewed changes
Comment threadDoc/library/functions.rst Outdated

See :func:`ast.literal_eval` for a function that can safely evaluate strings
with expressions containing only literals.
.. versionchanged:: 3.11

@slatenyslatenyDec 20, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not so sure about saying 'version changed', as it seems to imply that only 3.11 has the change, but 3.10 also has it as it was backported (see PR). I'd say it's okay to just keep the original format and adjust the wording.

@ramvikramsramvikramsDec 20, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@slateny
slateny requested a review from gpsheadDecember 20, 2022 08:07
@slatenyslateny changed the title gh-100305: ast.literal_eval is still referred to as safe by the documentation for evalgh-100305: Deemphasize that ast.literal_eval is safe in eval documentationDec 20, 2022
merwok
merwok reviewed Nov 17, 2025
View reviewed changes
Comment threadDoc/library/functions.rst Outdated
@github-actions

github-actionsBot commented Apr 12, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsBot added the stale Stale PR or inactive for long period of time. label Apr 12, 2026
@gpshead@merwok
don't scare quotes safely, just say to
e388fd4
Co-authored-by: Éric <merwok@netwok.org>
@gpshead
gpshead enabled auto-merge (squash) April 12, 2026 03:00
@gpsheadgpshead added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Apr 12, 2026
@gpsheadgpshead moved this from Todo to Done in Docs PRsApr 12, 2026
@gpshead
gpshead merged commit b3b0cef into python:mainApr 12, 2026
34 checks passed
@miss-islington-app

miss-islington-appBot commented Apr 12, 2026

Copy link
Copy Markdown

Thanks @ramvikrams for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 12, 2026
@ramvikrams@merwok@miss-islington
pythongh-100305: Deemphasize thatast.literal_evalis safe in `eval…
e927748
…` documentation (pythonGH-100326)
(cherry picked from commit b3b0cef)
Co-authored-by: Ram Vikram Singh <ramvikrams243@gmail.com>
Co-authored-by: Éric <merwok@netwok.org>
@bedevere-app

bedevere-appBot commented Apr 12, 2026

Copy link
Copy Markdown

GH-148420 is a backport of this pull request to the 3.14 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 12, 2026
@ramvikrams@merwok@miss-islington
pythongh-100305: Deemphasize thatast.literal_evalis safe in `eval…
0f58608
…` documentation (pythonGH-100326)
(cherry picked from commit b3b0cef)
Co-authored-by: Ram Vikram Singh <ramvikrams243@gmail.com>
Co-authored-by: Éric <merwok@netwok.org>
@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Apr 12, 2026
@bedevere-app

bedevere-appBot commented Apr 12, 2026

Copy link
Copy Markdown

GH-148421 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Apr 12, 2026
StanFromIreland pushed a commit that referenced this pull request Apr 15, 2026
@miss-islington@ramvikrams@merwok
[3.13]gh-100305: Deemphasize thatast.literal_evalis safe in `eva…
9c2db81
…l` documentation (GH-100326) (#148421)
(cherry picked from commit b3b0cef)
Co-authored-by: Ram Vikram Singh <ramvikrams243@gmail.com>
Co-authored-by: Éric <merwok@netwok.org>
StanFromIreland pushed a commit that referenced this pull request Apr 15, 2026
@miss-islington@ramvikrams@merwok
[3.14]gh-100305: Deemphasize thatast.literal_evalis safe in `eva…
0d2101d
…l` documentation (GH-100326) (#148420)
(cherry picked from commit b3b0cef)
Co-authored-by: Ram Vikram Singh <ramvikrams243@gmail.com>
Co-authored-by: Éric <merwok@netwok.org>
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@ramvikrams@merwok@ljfp
pythongh-100305: Deemphasize thatast.literal_evalis safe in `eval…
c5602a0
…` documentation (python#100326)
Co-authored-by: Éric <merwok@netwok.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwokmerwokmerwok left review comments
@slatenyslatenyslateny left review comments
@gpsheadgpsheadgpshead approved these changes

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip newsstaleStale PR or inactive for long period of time.

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ramvikrams@gpshead@merwok@slateny@bedevere-bot@nazeerali4325-commits