gh-100220: Fix error handling in make rules

[mgorny]

Use set -e before compound shell commands in order to ensure that make targets fail correctly when at least one of the subcommands fail.

This is necessary since make considers a target failed only if one of the shell invocations returns with unsuccessful exit status. If a shell script does not exit explicitly, the shell uses the exit status of the last executed command. This means that when multiple commands are executed (e.g. through a for loop), the exit statuses of prior command invocations are ignored.

This can be either resolved by adding an explicit || exit 1 to every command that is expected to succeed, or by running the whole script with set -e. The latter was used here as it the rules seem to be written with the assumption that individual commands were supposed to cause the make rules to fail.

• Issue: make sharedinstall does not return failure if install commands fail #100220

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @merwok for commit 65d6cdb 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

[zware]

This looks good, but is going to need some conflict resolution now after GH-100329.

I wonder if this could be achieved with less churn by setting SHELL := $(SHELL) -e?

[mgorny]

This looks good, but is going to need some conflict resolution now after GH-100329.

Done.

I wonder if this could be achieved with less churn by setting SHELL := $(SHELL) -e?

Hmm, I haven't though of that. I suppose it could work too.

[merwok]

Please use regular merges and pushes for Python repos, force-pushes give reviewers a poor experience on github.

[mgorny]

@zware, do you want to rework this to try updating this to use SHELL right now or is this good as-is?

[zware]

If the SHELL method works and doesn't break anything else, I'd rather go that route. That way we don't have to worry about making sure new commands start with the right magic incantation, and the history is much cleaner.

[mgorny]

Switched to the SHELL approach, though the Makefile already sets SHELL, so I've just appended -e there. I've tested it and it seems to work fine: successful build succeeds, and broken build fails.

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @zware for commit 86c946f 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

[zware]

The two buildbot failures don't appear to have anything to do with this; they shouldn't block a merge.

@kushaldas, you had assigned yourself to this one; WDYT?

[mgorny]

Ping.

[mgorny]

Thank you!