Uh oh!
There was an error while loading. Please reload this page.
document positional-only arguments for collections.deque - #100444
document positional-only arguments for collections.deque#100444asottile wants to merge 1 commit into
Conversation
asottile
commented
Dec 22, 2022
ran into this accidentally while using pypy and then was surprised when I used cpython and it didn't work |
rhettinger
commented
Dec 23, 2022
I believe there was a decision to NOT broadly apply this across the documentation. The notion was the |
rhettinger
commented
Dec 23, 2022
Thanks for the suggestion, but let's wait until there is a collective decision to go forward with doing this to all the docs, not just |
asottile
commented
Dec 23, 2022
then should these be removed? $ git grep -E '^\.\. (method|function):: .*/[,)]' -- Doc/ | head -5Doc/library/_thread.rst:.. function:: interrupt_main(signum=signal.SIGINT, /)Doc/library/binascii.rst:.. function:: a2b_base64(string, /, *, strict_mode=False)Doc/library/curses.rst:.. function:: wrapper(func, /, *args, **kwargs)Doc/library/dataclasses.rst:.. function:: replace(obj, /, **changes)Doc/library/functions.rst:.. function:: eval(expression, /, globals=None, locals=None)
$ git grep -E '^\.\. (method|function):: .*/[,)]' -- Doc/ | wc -l107 |
rhettinger
commented
Dec 23, 2022
No, I wouldn't remove them. Occasionally, some are added at the discretion of the maintainer when they think it might be useful. Previously, I mentioned And while I didn't make any of the edits that you found, I'm not worried about them. The users of Side note. I recommend not going down the path of "give me an exact, clearly defined rule, then I will sweep through the docs and apply it everywhere without consideration to each individual case". It is a tempting path, but our world is more nuanced than that and not all the developers agree on all the little decisions. To start contributing, I recommend starting with filed bug reports so that changes are directed at solving known user issues. In the past, Guido has advocated "holistic refactoring" focusing on the zeitgeist and needs of a particular module and its user base rather than non-holistic mark-and-sweep PRs (put another way, don't start by running |
asottile
commented
Dec 23, 2022
yeah I'm not exactly new here but appreciate the message nonetheless |
rhettinger
commented
Dec 23, 2022
Yes, of course, I know who you are. Just wanted to give a more thoughtful answer to your question than just "no" ;-) |
No description provided.