Skip to content

gh-100288: Specialise LOAD_ATTR_METHOD for managed dictionaries - #100492

Closed
Fidget-Spinner wants to merge 7 commits into
python:mainfrom
Fidget-Spinner:more_load_attr
Closed

gh-100288: Specialise LOAD_ATTR_METHOD for managed dictionaries#100492
Fidget-Spinner wants to merge 7 commits into
python:mainfrom
Fidget-Spinner:more_load_attr

Conversation

@Fidget-Spinner

@Fidget-SpinnerFidget-Spinner commented Dec 24, 2022

Copy link
Copy Markdown
Member

@Fidget-SpinnerFidget-Spinner added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 24, 2022
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @Fidget-Spinner for commit 576c914 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 24, 2022
Comment threadPython/bytecodes.c Outdated
@markshannon

Copy link
Copy Markdown
Member

The stats show only a small increase in specialization effectiveness, and that the new instruction has a 40% miss rate.

I think we would be better off trying to reduce the number of objects with dictionaries than specializing for that case.

@Fidget-Spinner

Copy link
Copy Markdown
MemberAuthor

Hmm yes hit rate only went from 82.0% to 82.5%. This isn't worthwhile.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Fidget-Spinner@bedevere-bot@markshannon@brandtbucher