Skip to content

gh-100540: Remove obsolete Modules/_ctypes/darwin/ dlfcn shim - #100541

Merged
zware merged 1 commit into
python:mainfrom
zware:remove__ctypes_dlfcn_shim
Dec 29, 2022
Merged

gh-100540: Remove obsolete Modules/_ctypes/darwin/ dlfcn shim#100541
zware merged 1 commit into
python:mainfrom
zware:remove__ctypes_dlfcn_shim

Conversation

@zware

@zwarezware commented Dec 26, 2022•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

As far as I can tell, this hasn't been actually used since Mac OS X 10.2.

@zware
zware requested a review from a team as a code ownerDecember 26, 2022 20:54
@zwarezware added 3.12 only security fixes OS-mac build The build process and cross-build topic-ctypes extension-modules C modules in the Modules dir labels Dec 26, 2022
@zwarezware self-assigned this Dec 26, 2022
@bedevere-botbedevere-bot mentioned this pull request Dec 26, 2022
Closed
@zware

zware commented Dec 26, 2022•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

!buildbot macos

@bedevere-bot

bedevere-bot commented Dec 26, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @zware for commit 67d159c 🤖

The command will test the builders whose names match following regular expression: macOS

The builders matched are:

@zware

zware commented Dec 26, 2022

Copy link
Copy Markdown
MemberAuthor

!buildbot .*mac

@bedevere-bot

bedevere-bot commented Dec 26, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @zware for commit 67d159c 🤖

The command will test the builders whose names match following regular expression: .*mac

The builders matched are:

  • ARM64 macOS PR
  • x86-64 macOS PR

@zware
zware requested a review from a teamDecember 26, 2022 21:00
@arhadthedev

arhadthedev commented Dec 27, 2022

Copy link
Copy Markdown
Member

Probably, this should be removed too:

cpython/Tools/c-analyzer/cpython/_parser.py

Line 54 in 199507b

#Modules/_ctypes/darwin/*.c

@zware
zwareforce-pushed the remove__ctypes_dlfcn_shim branch from 67d159c to 73b501eCompareDecember 27, 2022 19:30
@zware

zware commented Dec 27, 2022

Copy link
Copy Markdown
MemberAuthor

Probably, this should be removed too:

Ah, thanks; I missed that one here, though I got the neighboring one in GH-100543.

@zware
zwareforce-pushed the remove__ctypes_dlfcn_shim branch from 73b501e to b2b2802CompareDecember 28, 2022 19:37
@zware
pythongh-100540: Remove obsolete Modules/_ctypes/darwin/ dlfcn shim
2404f50
As far as I can tell, this hasn't been actually used since Mac OS X 10.2.
@zware
zwareforce-pushed the remove__ctypes_dlfcn_shim branch from b2b2802 to 2404f50CompareDecember 28, 2022 19:41
ronaldoussoren
ronaldoussoren approved these changes Dec 29, 2022
View reviewed changes

@ronaldoussorenronaldoussoren left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch looks good to me.

@zware
zware merged commit 2df82db into python:mainDec 29, 2022
@zware
zware deleted the remove__ctypes_dlfcn_shim branch December 29, 2022 22:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronaldoussorenronaldoussorenronaldoussoren approved these changes

Assignees

@zwarezware

Labels

3.12only security fixesbuildThe build process and cross-buildextension-modulesC modules in the Modules dirOS-mactopic-ctypes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zware@bedevere-bot@arhadthedev@ronaldoussoren