Skip to content

gh-100689: Revert "bpo-41798: pyexpat: Allocate the expat_CAPI on the… - #100745

Merged
kumaraditya303 merged 8 commits into
python:mainfrom
sobolevn:issue-100689
Jan 8, 2023
Merged

gh-100689: Revert "bpo-41798: pyexpat: Allocate the expat_CAPI on the…#100745
kumaraditya303 merged 8 commits into
python:mainfrom
sobolevn:issue-100689

Conversation

@sobolevn

@sobolevnsobolevn commented Jan 4, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

… heap memory (GH-24061)"

This reverts commit 7c83eaa.

This would need to be back-ported to 3.10 and 3.11

@bedevere-botbedevere-bot mentioned this pull request Jan 4, 2023
Closed
kumaraditya303
kumaraditya303 requested changes Jan 4, 2023
View reviewed changes

@kumaraditya303kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a news entry as this is a bug fix.

@bedevere-bot

bedevere-bot commented Jan 4, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

@sobolevn

sobolevn commented Jan 4, 2023

Copy link
Copy Markdown
MemberAuthor

Done! I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Jan 4, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@kumaraditya303: please review the changes made to this pull request.

kumaraditya303
kumaraditya303 reviewed Jan 4, 2023
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2023-01-04-12-58-59.gh-issue-100689.Ce0ITG.rst Outdated
@kumaraditya303kumaraditya303 added the type-crash A hard crash of the interpreter, possibly with a core dump label Jan 4, 2023
kumaraditya303
kumaraditya303 reviewed Jan 4, 2023
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2023-01-04-12-58-59.gh-issue-100689.Ce0ITG.rst Outdated
erlend-aasland
erlend-aasland reviewed Jan 4, 2023
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2023-01-04-12-58-59.gh-issue-100689.Ce0ITG.rst Outdated
@SoulReaverFan

SoulReaverFan commented Jan 7, 2023

Copy link
Copy Markdown

Thank you so much for your work on fixing this issue. It is very much appreciated 👍

kumaraditya303
kumaraditya303 reviewed Jan 8, 2023
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2023-01-04-12-58-59.gh-issue-100689.Ce0ITG.rst Outdated
@kumaraditya303
kumaraditya303 merged commit b034fd3 into python:mainJan 8, 2023
@miss-islington

miss-islington commented Jan 8, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jan 8, 2023

Copy link
Copy Markdown

GH-100846 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Jan 8, 2023
@bedevere-bot

bedevere-bot commented Jan 8, 2023

Copy link
Copy Markdown

GH-100847 is a backport of this pull request to the 3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Jan 8, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 8, 2023
@sobolevn@miss-islington
pythongh-100689: Revert "bpo-41798: pyexpat: Allocate the expat_CAPI …
a65e93e
…on the heap memory (pythonGH-24061)" (pythonGH-100745)
* pythongh-100689: Revert "bpo-41798: pyexpat: Allocate the expat_CAPI on the heap memory (pythonGH-24061)"
This reverts commit 7c83eaa.
(cherry picked from commit b034fd3)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 8, 2023
@sobolevn@miss-islington
pythongh-100689: Revert "bpo-41798: pyexpat: Allocate the expat_CAPI …
30b8ac2
…on the heap memory (pythonGH-24061)" (pythonGH-100745)
* pythongh-100689: Revert "bpo-41798: pyexpat: Allocate the expat_CAPI on the heap memory (pythonGH-24061)"
This reverts commit 7c83eaa.
(cherry picked from commit b034fd3)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull request Jan 8, 2023
@miss-islington@sobolevn
gh-100689: Revert "bpo-41798: pyexpat: Allocate the expat_CAPI on the…
6c7e32f
… heap memory (GH-24061)" (GH-100745)
* gh-100689: Revert "bpo-41798: pyexpat: Allocate the expat_CAPI on the heap memory (GH-24061)"
This reverts commit 7c83eaa.
(cherry picked from commit b034fd3)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
kumaraditya303 pushed a commit that referenced this pull request Jan 8, 2023
@miss-islington@sobolevn
[3.10]gh-100689: Revert "bpo-41798: pyexpat: Allocate the expat_CAPI…
0e00bce
… on the heap memory (GH-24061)" (GH-100745) (#100847)
gh-100689: Revert "bpo-41798: pyexpat: Allocate the expat_CAPI on the heap memory (GH-24061)" (GH-100745)
* gh-100689: Revert "bpo-41798: pyexpat: Allocate the expat_CAPI on the heap memory (GH-24061)"
This reverts commit 7c83eaa.
(cherry picked from commit b034fd3)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes
@kumaraditya303kumaraditya303kumaraditya303 approved these changes

Assignees

No one assigned

Labels

release-blockertype-crashA hard crash of the interpreter, possibly with a core dump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sobolevn@bedevere-bot@SoulReaverFan@miss-islington@erlend-aasland@kumaraditya303