Skip to content

GH-98831: Identify instructions that don't use oparg - #100957

Merged
gvanrossum merged 4 commits into
python:mainfrom
gvanrossum:cases-oparg
Jan 14, 2023
Merged

GH-98831: Identify instructions that don't use oparg#100957
gvanrossum merged 4 commits into
python:mainfrom
gvanrossum:cases-oparg

Conversation

@gvanrossum

@gvanrossumgvanrossum commented Jan 11, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

For these the instr_format field uses I_ instead of IB.
Register instructions use I_, IB, IBB_, IBBB, etc.

@gvanrossum
Identify instructions that don't use oparg
6f88a1d
For these the instr_format field uses I_ instead of IB.
Register instructions use I_, IB, IBB_, IBBB, etc.
@bedevere-botbedevere-bot mentioned this pull request Jan 11, 2023
Closed
brandtbucher
brandtbucher requested changes Jan 12, 2023
View reviewed changes

@brandtbucherbrandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, just a bit confused by the register formats you're generating.

Comment threadTools/cases_generator/generate_cases.py
fmt = "I" + "B"*num_regs + "_"*num_dummies
else:
fmt = "IB"
if variable_used(inst.block, "oparg"):

@brandtbucherbrandtbucherJan 12, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't know the actual opcode values yet, do we? If so, maybe we want to warn or something if this conflicts with HAVE_ARGUMENT.

@gvanrossumgvanrossumJan 12, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alas, we don't. I'd have to load opcode.py using the hack from your PR, which feels more infrastructure than I want to invest in for now (nothing is using the opcode metadata yet).

Comment threadPython/opcode_metadata.h Outdated
Comment threadTools/cases_generator/generate_cases.py Outdated
@bedevere-bot

bedevere-bot commented Jan 12, 2023

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@gvanrossum

gvanrossum commented Jan 12, 2023

Copy link
Copy Markdown
MemberAuthor

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Jan 12, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@brandtbucher: please review the changes made to this pull request.

@gvanrossum
gvanrossum merged commit 5134ef4 into python:mainJan 14, 2023
@gvanrossum
gvanrossum deleted the cases-oparg branch January 14, 2023 01:06
@gvanrossumgvanrossum mentioned this pull request Jan 16, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucherbrandtbucherbrandtbucher approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gvanrossum@bedevere-bot@brandtbucher