Skip to content

[3.11] Clarify re docs for byte pattern group names (GH-99308) - #101001

Merged
hauntsaninja merged 1 commit into
python:3.11from
GreatFruitOmsk:fix-re-docstring-3.11
Mar 4, 2023
Merged

[3.11] Clarify re docs for byte pattern group names (GH-99308)#101001
hauntsaninja merged 1 commit into
python:3.11from
GreatFruitOmsk:fix-re-docstring-3.11

Conversation

@Kentzo

@KentzoKentzo commented Jan 12, 2023

Copy link
Copy Markdown
Contributor

@slateny

Copy link
Copy Markdown
Contributor

Per comment I don't believe there should be a backport for this.

@Kentzo

Copy link
Copy Markdown
ContributorAuthor

#99308 (comment) says otherwise

@CAM-GerlachCAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Kentzo . One set of suggestions, otherwise LGTM

Comment threadDoc/library/re.rst
Comment threadDoc/library/re.rst
Comment threadDoc/library/re.rst

@hauntsaninjahauntsaninja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for backporting this!

Looks like it's common enough for past versions of docs to contain "removed" for future versions of Python, so would you mind applying CAM's suggestions?

Edit: Since this has been lying around, I think this is fine to merge as is without the more specific directives; 3.12 isn't finalised and this seems like a short time between deprecation and removal.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Kentzo@slateny@hauntsaninja@CAM-Gerlach@bedevere-bot