Uh oh!
There was an error while loading. Please reload this page.
gh-101037: Fix potential memory underallocation for zeros of int subtypes - #101038
Conversation
mdickinson
commented
Jan 14, 2023
@corona10 Would you be willing to review? |
mdickinson
commented
Jan 14, 2023
Just a comment: this seems fairly harmless in this case, but I'd note that we don't in general do anything special to make sure that |
bedevere-bot
commented
Jan 14, 2023
🤖 New build scheduled with the buildbot fleet by @mdickinson for commit 2ddd5c1 🤖 If you want to schedule another build, you need to add the |
@mdickinson I will take a look. Thanks |
corona10
commented
Jan 15, 2023
For refleak: |
There was a problem hiding this comment.
LGTM
The refleak is unrelated to this PR :)
see: #100998 (comment)
2ddd5c1 to
877067cComparebedevere-bot
commented
Jan 20, 2023
corona10
commented
Jan 20, 2023
@mdickinson Oops, sorry, I tried to rebase the branch for |
mdickinson
commented
Jan 21, 2023
@corona10 No problem; thanks for reviewing! |
miss-islington
commented
Jan 21, 2023
Thanks @mdickinson for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
…t subtypes (pythonGH-101038) This PR fixes object allocation in long_subtype_new to ensure that there's at least one digit in all cases, and makes sure that the value of that digit is copied over from the source long. Needs backport to 3.11, but not any further: the change to require at least one digit was only introduced for Python 3.11. FixespythonGH-101037. (cherry picked from commit 401fdf9) Co-authored-by: Mark Dickinson <dickinsm@gmail.com>
bedevere-bot
commented
Jan 21, 2023
GH-101219 is a backport of this pull request to the 3.11 branch. |
…nt subtypes (GH-101038) (#101219) gh-101037: Fix potential memory underallocation for zeros of int subtypes (GH-101038) This PR fixes object allocation in long_subtype_new to ensure that there's at least one digit in all cases, and makes sure that the value of that digit is copied over from the source long. Needs backport to 3.11, but not any further: the change to require at least one digit was only introduced for Python 3.11. FixesGH-101037. (cherry picked from commit 401fdf9) Co-authored-by: Mark Dickinson <dickinsm@gmail.com>
This PR fixes object allocation in
long_subtype_newto ensure that there's at least one digit in all cases, and makes sure that the value of that digit is copied over from the sourcelong.Needs backport to 3.11, but not any further: the change to require at least one digit was only introduced for Python 3.11.
Fixes#101037.