Skip to content

gh-89381: Fix invalid signatures of math/cmath.log - #101070

Closed
skirpichev wants to merge 1 commit into
python:mainfrom
skirpichev:fix-89381
Closed

gh-89381: Fix invalid signatures of math/cmath.log#101070
skirpichev wants to merge 1 commit into
python:mainfrom
skirpichev:fix-89381

Conversation

@skirpichev

@skirpichevskirpichev commented Jan 16, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@bedevere-botbedevere-bot mentioned this pull request Jan 16, 2023
Open
@hauntsaninja

hauntsaninja commented Jan 18, 2023

Copy link
Copy Markdown
Contributor

Thanks for the PR! I was curious about why the existing code in mathmodule.c didn't work. It turns out that it is I think easy to fix, which led me to make an alternate PR here: #101115.

I think that PR is a slightly smaller change / closer to what whoever did the original argument clinic for mathmodule.c intended. But maybe c_default is sketchy or support for None is desirable, in which case this PR works too!

@skirpichevskirpichev mentioned this pull request Jan 18, 2023
Closed
@skirpichev

skirpichev commented Jan 18, 2023

Copy link
Copy Markdown
MemberAuthor

@hauntsaninja, thanks. I left few notes on the new PR.

@skirpichev

skirpichev commented Jan 19, 2023

Copy link
Copy Markdown
MemberAuthor

Closed per #101123

@skirpichev
skirpichev deleted the fix-89381 branch January 19, 2023 07:48
mdickinson
mdickinson reviewed Jan 29, 2023
View reviewed changes
Comment threadDoc/library/cmath.rst
Returns the logarithm of *x* to the given *base*. If the *base* is not
specified, returns the natural logarithm of *x*. There is one branch cut, from 0
along the negative real axis to -∞, continuous from above.
specified or is None, returns the natural logarithm of *x*. There is one

@mdickinsonmdickinsonJan 29, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the interests of readability, I'd suggest reverting the change on this line - I think it's clear from context that "not specified" includes the case of deliberately specifying None.

@skirpichevskirpichev mentioned this pull request Jan 29, 2023
Merged
@skirpichev

skirpichev commented Jan 29, 2023

Copy link
Copy Markdown
MemberAuthor

reopened as #101404

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mdickinsonmdickinsonmdickinson left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@skirpichev@hauntsaninja@mdickinson@bedevere-bot