Uh oh!
There was an error while loading. Please reload this page.
gh-98831: register instructions have 0 pushes and pops - #101163
Conversation
gvanrossum
left a comment
There was a problem hiding this comment.
Good call!
Maybe it's time to add some tests for the generated opcode metadata (but I'm not asking for that now).
iritkatriel
commented
Jan 19, 2023
It failed very quickly when I tried to use it (the sanity check we added in the compiler flipped). |
Is it ready to merge? Note: there are other things in the generator that probably don't work, e.g. there are some commented-out |
iritkatriel
commented
Jan 19, 2023
I think so.
I'm not doing variable length instructions now. I'm adding the plumbing in the compiler, and for now supporting only 1 oparg (so I can do RETURN_VALUE from a tmp register). There's plenty there to keep me busy for now. |
Uh oh!
There was an error while loading. Please reload this page.