Uh oh!
There was an error while loading. Please reload this page.
GH-92123: Pass _elementtree state as parameter - #101189
Conversation
erlend-aasland
commented
Jan 20, 2023
Passing the state around as a parameter is one way to get rid of |
erlend-aasland
commented
Jan 20, 2023
(I will rebase this onto |
f0117f3 to
5fd0b8aComparePass state as arg to create_new_element()
Pass state as arg to deepcopy()
Pass state as arg to expat_set_error()
Pass state as arg to element_setstate_from_attributes()
Pass state as arg to create_elementiter()
Pass state as arg to treebuilder_extend_element_text_or_tail()
Pass state as arg to treebuilder_add_subelement()
Pass state as arg to element_add_subelement()
Pass state as arg to element_setstate_from_Python()
b853fba to
fbd465aComparefbd465a to
0195c35Compareerlend-aasland
commented
Jan 23, 2023
cc. @arhadthedev |
After this, the remaining parts are:
|
Up to you but I can review of all this in one go, they are relatively small changes. |
kumaraditya303
commented
Jan 24, 2023
Side thought: |
erlend-aasland
commented
Jan 24, 2023
Yes; well observed. |
Complement to #101190