Skip to content

gh-101277: Finalise isolating itertools - #101305

Merged
miss-islington merged 24 commits into
python:mainfrom
erlend-aasland:isolate-itertools/batch-4
Feb 10, 2023
Merged

gh-101277: Finalise isolating itertools#101305
miss-islington merged 24 commits into
python:mainfrom
erlend-aasland:isolate-itertools/batch-4

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Jan 24, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Add repeat, islice, chain, tee, teedataobject, and batched types to module state.

Automerge-Triggered-By: GH:erlend-aasland

@bedevere-botbedevere-bot mentioned this pull request Jan 24, 2023
Closed
@erlend-aasland
erlend-aaslandforce-pushed the isolate-itertools/batch-4 branch from 244bc33 to e5bf6f8CompareJanuary 25, 2023 09:02
@erlend-aasland
erlend-aaslandforce-pushed the isolate-itertools/batch-4 branch from e5bf6f8 to a9b84f0CompareFebruary 1, 2023 14:27
@erlend-aasland
erlend-aaslandforce-pushed the isolate-itertools/batch-4 branch from a9b84f0 to 930fbe1CompareFebruary 8, 2023 20:29
@erlend-aasland
erlend-aaslandforce-pushed the isolate-itertools/batch-4 branch from ed58cc0 to c4981ffCompareFebruary 8, 2023 20:52
erlend-aasland
erlend-aasland commented Feb 8, 2023
View reviewed changes
Comment threadModules/itertoolsmodule.c
@erlend-aaslanderlend-aasland changed the title gh-101277: Isolate itertools, part 4/4gh-101277: Finalise isolating itertoolsFeb 8, 2023
@erlend-aasland
erlend-aasland marked this pull request as ready for review February 8, 2023 21:50
@erlend-aaslanderlend-aasland added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 8, 2023
@erlend-aaslanderlend-aasland added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 9, 2023
@bedevere-bot

bedevere-bot commented Feb 9, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 9f68cd1 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 9, 2023
@erlend-aaslanderlend-aasland added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 9, 2023
@bedevere-bot

bedevere-bot commented Feb 9, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit a9c6ce5 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 9, 2023
arhadthedev
arhadthedev reviewed Feb 10, 2023
View reviewed changes
Comment threadModules/itertoolsmodule.c Outdated
@erlend-aaslanderlend-aasland added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 10, 2023
@bedevere-bot

bedevere-bot commented Feb 10, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 5213d1f 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 10, 2023
kumaraditya303
kumaraditya303 reviewed Feb 10, 2023
View reviewed changes
Comment threadModules/itertoolsmodule.c
@erlend-aasland

erlend-aasland commented Feb 10, 2023

Copy link
Copy Markdown
ContributorAuthor

Thanks for the reviews, Kumar. Highly appreciated.

@miss-islington

miss-islington commented Feb 10, 2023

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅.

@miss-islington
miss-islington merged commit 826bf0e into python:mainFeb 10, 2023
@erlend-aasland
erlend-aasland deleted the isolate-itertools/batch-4 branch February 10, 2023 11:59
@kumaraditya303

kumaraditya303 commented Feb 10, 2023

Copy link
Copy Markdown
Contributor

Thanks for the reviews, Kumar. Highly appreciated.

Thanks for all your work on this!

@erlend-aasland

erlend-aasland commented Feb 10, 2023

Copy link
Copy Markdown
ContributorAuthor

Thanks for all your work on this!

_io next?

@kumaraditya303

kumaraditya303 commented Feb 10, 2023

Copy link
Copy Markdown
Contributor

_io next?

Go ahead! I expect that there will be some bootstrapping issues but I'll help you out.

carljm added a commit to carljm/cpython that referenced this pull request Feb 10, 2023
@carljm
Merge branch 'main' into inlinecomp2
36b2917
* main:
Docs: Fix getstatus() -> getcode() typos (python#101296)
Docs: use parameter list for sqlite3.Cursor.execute* (python#101782)
pythongh-101763: Update bundled copy of libffi to 3.4.4 on Windows (pythonGH-101784)
pythongh-101517: make bdb avoid looking up in linecache with lineno=None (python#101787)
pythongh-101759: Update Windows installer to SQLite 3.40.1 (python#101762)
pythongh-101277: Finalise isolating itertools (pythonGH-101305)
pythongh-101759: Update macOS installer to SQLite 3.40.1 (python#101761)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arhadthedevarhadthedevarhadthedev left review comments
@kumaraditya303kumaraditya303kumaraditya303 approved these changes
@rhettingerrhettingerAwaiting requested review from rhettingerrhettinger is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland@bedevere-bot@miss-islington@kumaraditya303@arhadthedev