Skip to content

gh-71966: Sync-up docstrings in C version of the the decimal module - #101350

Open
furkanonder wants to merge 69 commits into
python:mainfrom
furkanonder:issue-71966
Open

gh-71966: Sync-up docstrings in C version of the the decimal module#101350
furkanonder wants to merge 69 commits into
python:mainfrom
furkanonder:issue-71966

Conversation

@furkanonder

@furkanonderfurkanonder commented Jan 26, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-botbedevere-bot mentioned this pull request Jan 26, 2023
Open
@rhettingerrhettinger self-assigned this Jan 27, 2023
@furkanonderfurkanonder changed the title GH-71966: Sync-up docstrings in C version of the the decimal modulegh-71966: Sync-up docstrings in C version of the the decimal moduleAug 6, 2023
serhiy-storchaka
serhiy-storchaka reviewed Jan 16, 2024
View reviewed changes
Comment threadModules/_decimal/docstrings.h
Comment threadLib/_pydecimal.py
Comment threadLib/_pydecimal.py Outdated
Comment threadModules/_decimal/docstrings.h Outdated
Comment threadModules/_decimal/docstrings.h Outdated
erlend-aasland
erlend-aasland reviewed Mar 3, 2024
View reviewed changes

@erlend-aaslanderlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the imperative mood consistently for reference text.

Comment threadLib/_pydecimal.py Outdated
Comment threadModules/_decimal/docstrings.h Outdated
Comment threadModules/_decimal/docstrings.h Outdated
Comment threadModules/_decimal/docstrings.h
Comment threadModules/_decimal/docstrings.h
Comment threadModules/_decimal/docstrings.h Outdated
Comment threadModules/_decimal/docstrings.h Outdated
Comment threadModules/_decimal/docstrings.h Outdated
Comment threadModules/_decimal/docstrings.h Outdated
Comment threadModules/_decimal/docstrings.h Outdated
furkanonderand others added 8 commits April 15, 2024 21:40
@furkanonder@erlend-aasland
Use the imperative mood
7ec70fb
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@furkanonder@erlend-aasland
Use the imperative mood
5596afd
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@furkanonder@erlend-aasland
Use the imperative mood
d76c6dc
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@furkanonder@erlend-aasland
Use the imperative mood
320d6b7
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@furkanonder@erlend-aasland
Use the imperative mood
35907ac
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@furkanonder@erlend-aasland
Use the imperative mood
84ad628
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@furkanonder@erlend-aasland
Use the imperative mood
77d6ea7
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@furkanonder@erlend-aasland
Use the imperative mood
d5c81c1
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
furkanonderand others added 24 commits April 16, 2024 01:51
@furkanonder
Sync-up docstring for canonical function
c067c35
@furkanonder
Sync-up docstring for compare_signal function
f117498
@furkanonder
Sync-up docstring for compare_total function
b1c5f94
@furkanonder
Sync-up docstring for conjugate function
a283af7
@furkanonder
Sync-up docstring for logical_and function
d4eae92
@furkanonder
Sync-up docstring for logical_invert function
1fd52d2
@furkanonder
Sync-up docstring for logical_or function
5c4ce3c
@furkanonder
Sync-up docstring for logical_xor function
8786c92
@furkanonder
Sync-up docstring for max function
c1d87e0
@furkanonder
Sync-up docstring for max_mag function
6b13483
@furkanonder
Sync-up docstring for min function
cdeac33
@furkanonder
Sync-up docstring for min_mag function
45be158
@furkanonder
Sync-up docstring for next_minus function
0354723
@furkanonder
Sync-up docstring for quantize function
0fd9ee4
@furkanonder
Sync-up docstring for fma function
50595fa
@furkanonder@erlend-aasland
Use the imperative mood
1c8b9fd
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@furkanonder
Merge branch 'main' into issue-71966
334abe0
@furkanonder@erlend-aasland
Use the imperative mood
ff0c52c
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@furkanonder
Use the imperative mood
1b34403
@furkanonder@erlend-aasland
Use the imperative mood
b8aa470
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@furkanonder
Sync-up docstring for max function
2af51d2
@furkanonder
Sync-up docstring for logical_xor, rotate and same_quantum function
c67ca48
@furkanonder
Sync-up docstring for min function
3302858
@furkanonder
Merge branch 'main' into issue-71966
d92ac62
@mdickinson
mdickinson removed their request for review May 14, 2024 07:30
@skirpichev

skirpichev commented Oct 19, 2025

Copy link
Copy Markdown
Member

@furkanonder, this now has merge conflicts. Are you interested to resolve them?

@furkanonder

furkanonder commented Oct 30, 2025

Copy link
Copy Markdown
ContributorAuthor

@furkanonder, this now has merge conflicts. Are you interested to resolve them?

Thanks for letting me know! I’ll take care of the merge conflicts and update the PR soon.

@skirpichev

skirpichev commented Oct 30, 2025

Copy link
Copy Markdown
Member

But please first take look on the issue thread. Maybe manual synchronization is not what we want here in a long term.

@github-actions

github-actionsBot commented Apr 12, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsBot added the stale Stale PR or inactive for long period of time. label Apr 12, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka left review comments
@erlend-aaslanderlend-aaslanderlend-aasland left review comments
@rhettingerrhettingerAwaiting requested review from rhettinger
@lisroachlisroachAwaiting requested review from lisroach

Assignees

@rhettingerrhettinger

Labels

awaiting reviewskip newsstaleStale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@furkanonder@skirpichev@serhiy-storchaka@erlend-aasland@rhettinger@bedevere-bot@nazeerali4325-commits