gh-99276 - Updated Doc/faq/general.rst by workingpayload · Pull Request #101396 · python/cpython

workingpayload · 2023-01-28T16:22:59Z

Issue: Add link to the first article about Python #99276

ghost · 2023-01-28T16:23:22Z

All commit authors signed the Contributor License Agreement.

hugovk

Thanks for the PR, but:

this is an article not a book, so doesn't belong in the books section
this article is already mentioned in the previous section about articles: https://docs.python.org/3/faq/general.html#are-there-any-published-articles-about-python-that-i-can-reference

Issue gh-99276 was about adding the https://ir.cwi.nl/pub/18204 article link to that articles section:

https://docs.python.org/3/faq/general.html#are-there-any-published-articles-about-python-that-i-can-reference

Please could you update the PR?

bedevere-bot · 2023-01-29T17:25:44Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

workingpayload · 2023-01-29T17:27:38Z

Thanks for the PR, but:
this is an article not a book, so doesn't belong in the books section
this article is already mentioned in the previous section about articles: https://docs.python.org/3/faq/general.html#are-there-any-published-articles-about-python-that-i-can-reference
Issue gh-99276 was about adding the https://ir.cwi.nl/pub/18204 article link to that articles section:
https://docs.python.org/3/faq/general.html#are-there-any-published-articles-about-python-that-i-can-reference
Please could you update the PR?

Yeah Sure!!

workingpayload · 2023-01-29T17:38:11Z

I have made the requested changes; please review again

bedevere-bot · 2023-01-29T17:38:16Z

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

hugovk · 2023-01-29T17:50:45Z

Rather than adding that extra line, shall we add an inline link?

For example, to add the link around "very first article":

-The very first article about Python was written in 1991 and is now quite-outdated.+The `very first article <https://ir.cwi.nl/pub/18204>` about Python was +written in 1991 and is now quite outdated.

workingpayload · 2023-01-29T17:54:29Z

Rather than adding that extra line, shall we add an inline link?
For example, to add the link around "very first article":
-The very first article about Python was written in 1991 and is now quite-outdated.+The `very first article <https://ir.cwi.nl/pub/18204>` about Python was +written in 1991 and is now quite outdated.

Yeah sure!!
I'll do that.
Thank you for helping me out.

…gpayload/cpython into workingpayload/issue99276

workingpayload · 2023-01-30T05:55:34Z

I have made the requested changes; please review again

bedevere-bot · 2023-01-30T05:55:37Z

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

workingpayload · 2023-01-30T09:54:32Z

I have made the requested changes; please review again

bedevere-bot · 2023-01-30T09:54:34Z

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

hugovk

Thanks!

miss-islington · 2023-01-31T15:16:21Z

Thanks @workingpayload for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

bedevere-bot · 2023-01-31T15:16:38Z

GH-101461 is a backport of this pull request to the 3.11 branch.

bedevere-bot · 2023-01-31T15:16:43Z

GH-101462 is a backport of this pull request to the 3.10 branch.

(cherry picked from commit df0068c) Co-authored-by: Raj <51259329+workingpayload@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

Co-authored-by: Raj <51259329+workingpayload@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

* main: pythongh-101440: fix json snippet error in logging-cookbook.rst (python#101439) pythongh-99276 - Updated Doc/faq/general.rst (python#101396) Add JOBS parameter to docs Makefile (python#101395) pythongh-98831: rewrite GET_LEN, GET_ITER, BEFORE_WITH and a few simple opcodes in the instruction definition DSL (python#101443) pythongh-77607: Improve accuracy of os.path.join docs (python#101406) Fixes typo in asyncio.TaskGroup context manager code example (python#101449) pythongh-98831: Clean up and add cache size static_assert to macro (python#101442) pythongh-99955: use SUCCESS/ERROR return values in optimizer and assembler. Use RETURN_IF_ERROR where appropriate. Fix a couple of bugs. (python#101412)

Issue#99276- Update Doc/faq/general.rst
ac7a9db

bedevere-bot added the awaiting review label Jan 28, 2023

bedevere-bot mentioned this pull request Jan 28, 2023
Add link to the first article about Python #99276
Closed

bedevere-bot added docs Documentation in the Doc dir skip news labels Jan 28, 2023

gh-99276- Updated Doc/faq/general.rst
53b96b2

hugovk requested changes Jan 29, 2023
View reviewed changes

bedevere-bot added awaiting changes and removed awaiting review labels Jan 29, 2023

gh-99276: Updated Doc/faq/general.rst
de44c07

bedevere-bot added awaiting change review and removed awaiting changes labels Jan 29, 2023

bedevere-bot requested a review from hugovk January 29, 2023 17:38

workingpayloadand others added 3 commits January 30, 2023 11:13

Merge branch 'main' into workingpayload/issue99276
85e34c3

gh-99276: Updated Doc/faq/general.rst
f3d6eb1

Merge branch 'workingpayload/issue99276' ofhttps://github.com/workin…
5e9dd81
…gpayload/cpython into workingpayload/issue99276

hugovk reviewed Jan 30, 2023
View reviewed changes

Comment threadDoc/faq/general.rst Outdated
Comment threadDoc/faq/general.rst Outdated

gh-99276: Updated Doc/faq/general.rst
96a2ebb

bedevere-bot requested a review from hugovk January 30, 2023 09:54

workingpayloadand others added 2 commits January 30, 2023 15:29

Update Doc/faq/general.rst
f50ec70
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

Merge branch 'main' into workingpayload/issue99276
4976d3a

hugovk reviewed Jan 30, 2023
View reviewed changes

Comment threadDoc/faq/general.rst Outdated

Update Doc/faq/general.rst
a211ee5
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

workingpayload requested a review from hugovk January 30, 2023 10:50

hugovk approved these changes Jan 30, 2023
View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Jan 30, 2023

hugovk added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jan 30, 2023

hugovk merged commit df0068c into python:mainJan 31, 2023

bedevere-bot removed the awaiting merge label Jan 31, 2023

bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 31, 2023

bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 31, 2023

hugovk added a commit that referenced this pull request Jan 31, 2023
[3.10]gh-99276- Updated Doc/faq/general.rst (GH-101396) (#101462)
ca11848
Co-authored-by: Raj <51259329+workingpayload@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

mdboom pushed a commit to mdboom/cpython that referenced this pull request Jan 31, 2023
pythongh-99276- Updated Doc/faq/general.rst (python#101396)
9fd32e8
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

workingpayload deleted the workingpayload/issue99276 branch February 1, 2023 16:59

Uh oh!

Uh oh!

Conversation

workingpayload commented Jan 28, 2023• edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jan 28, 2023• edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hugovk left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Jan 29, 2023

Uh oh!

workingpayload commented Jan 29, 2023

Uh oh!

workingpayload commented Jan 29, 2023

Uh oh!

bedevere-bot commented Jan 29, 2023

Uh oh!

hugovk commented Jan 29, 2023

Uh oh!

workingpayload commented Jan 29, 2023

Uh oh!

workingpayload commented Jan 30, 2023

Uh oh!

bedevere-bot commented Jan 30, 2023

Uh oh!

Uh oh!

Uh oh!

workingpayload commented Jan 30, 2023

Uh oh!

bedevere-bot commented Jan 30, 2023

Uh oh!

Uh oh!

hugovk left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Jan 31, 2023

Uh oh!

bedevere-bot commented Jan 31, 2023

Uh oh!

bedevere-bot commented Jan 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

workingpayload commented Jan 28, 2023•
edited by bedevere-bot
Loading

ghost commented Jan 28, 2023•
edited by ghost
Loading