Uh oh!
There was an error while loading. Please reload this page.
gh-101384: add socket timeout to ThreadedVSOCKSocketStreamTest and skip it on WSL - #101419
Merged
Merged
Conversation
peterjpxie
commented
Mar 25, 2023
ContributorAuthor
arhadthedev
commented
Mar 31, 2023
Member
@giampaolo, @gpshead (as networking experts) |
serhiy-storchaka
enabled auto-merge (squash)
February 17, 2024 08:53
serhiy-storchaka
commented
Feb 17, 2024
Member
A NEWS entry is not required here. |
Thanks @peterjpxie for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 17, 2024
…and skip it on WSL (pythonGH-101419) (cherry picked from commit 9fd420f) Co-authored-by: Peter Jiping Xie <peter.jp.xie@gmail.com>
GH-115585 is a backport of this pull request to the 3.12 branch. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 17, 2024
…and skip it on WSL (pythonGH-101419) (cherry picked from commit 9fd420f) Co-authored-by: Peter Jiping Xie <peter.jp.xie@gmail.com>
GH-115586 is a backport of this pull request to the 3.11 branch. |
serhiy-storchaka pushed a commit
that referenced
this pull request
Feb 17, 2024
serhiy-storchaka pushed a commit
that referenced
this pull request
Feb 17, 2024
woodruffw pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
diegorusso pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
LukasWoodtli pushed a commit
to LukasWoodtli/cpython
that referenced
this pull request
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1/ Add socket server timeout to ThreadedVSOCKSocketStreamTest so that it does not hang on client connection failure, e.g. on WSL.
After adding the timeout, it was able to fail on this test and continue as follows.
2/ Furthermore, as it does not work on WSL (OSError: [Errno 101] Network is unreachable), skip it on WSL.
This works on VMware workstation for communication between VM guests and host.
3/ With all the changes, this is the summary of tests on different platforms: