Skip to content

gh-101632: Add a RETURN_CONST instruction - #101633

Merged
iritkatriel merged 6 commits into
python:mainfrom
penguin-wwy:add_return_none
Feb 7, 2023
Merged

gh-101632: Add a RETURN_CONST instruction#101633
iritkatriel merged 6 commits into
python:mainfrom
penguin-wwy:add_return_none

Conversation

@penguin-wwy

@penguin-wwypenguin-wwy commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

@iritkatriel

Copy link
Copy Markdown
Member

Do you see a difference in any benchmarks?

@penguin-wwy

Copy link
Copy Markdown
ContributorAuthor

I am executing pyperformance, please wait :)

@penguin-wwy

Copy link
Copy Markdown
ContributorAuthor

@iritkatriel I update the pyperformance result in issue
#101632 (comment)

@arhadthedevarhadthedev added the performance Performance or resource usage label Feb 7, 2023
@iritkatriel

Copy link
Copy Markdown
Member

@iritkatriel I update the pyperformance result in issue
#101632 (comment)

Thanks, I'll try to replicate on our benchmark machine.

@iritkatriel

Copy link
Copy Markdown
Member

@iritkatriel I update the pyperformance result in issue
#101632 (comment)

Thanks, I'll try to replicate on our benchmark machine.

Also came out 1% faster.

Results are here.

@penguin-wwy

Copy link
Copy Markdown
ContributorAuthor

@iritkatriel I update the pyperformance result in issue
#101632 (comment)

Thanks, I'll try to replicate on our benchmark machine.

Also came out 1% faster.

Results are here.

Thanks. It turned out a little better than I expected.

@iritkatrieliritkatriel added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Feb 7, 2023
Comment threadLib/test/test_code.py
@iritkatrieliritkatriel changed the title gh-101632: Add return const instructiongh-101632: Add a RETURN_CONST instructionFeb 7, 2023

@iritkatrieliritkatriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iritkatrieliritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 7, 2023
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit afba682 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 7, 2023
@iritkatriel

Copy link
Copy Markdown
Member

The "s390x Fedora Refleaks PR" buildbot is broken (for a few months at least). All other test runs were successful.

@iritkatriel
iritkatriel merged commit 753fc8a into python:mainFeb 7, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

interpreter-core(Objects, Python, Grammar, and Parser dirs)performancePerformance or resource usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@penguin-wwy@iritkatriel@bedevere-bot@arhadthedev