Skip to content

gh-98239: Document that inspect.getsource() can raise TypeError - #101689

Merged
AlexWaygood merged 2 commits into
python:mainfrom
sobolevn:issue-98239
Mar 23, 2023
Merged

gh-98239: Document that inspect.getsource() can raise TypeError#101689
AlexWaygood merged 2 commits into
python:mainfrom
sobolevn:issue-98239

Conversation

@sobolevn

@sobolevnsobolevn commented Feb 8, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Now all inspect.getsourcefile, inspect.getsourcelines, and inspect.getsource mention the TypeError case.

cc @ericvsmith

@bedevere-botbedevere-bot mentioned this pull request Feb 8, 2023
Closed
@bedevere-botbedevere-bot added docs Documentation in the Doc dir skip news labels Feb 8, 2023
@sobolevn

sobolevn commented Mar 20, 2023

Copy link
Copy Markdown
MemberAuthor

@AlexWaygood this is quite a simple change, but it is stuck. Can you please take a look?

@AlexWaygood
AlexWaygood self-requested a review March 20, 2023 23:15
AlexWaygood
AlexWaygood reviewed Mar 23, 2023
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just two small suggestions to minimise the diff and keep the additions consistent with the immediate surrounding text:

Comment threadDoc/library/inspect.rst Outdated
Comment threadDoc/library/inspect.rst Outdated
@sobolevn@AlexWaygood
Apply suggestions from code review
d08f2d8
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@AlexWaygoodAlexWaygood added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Mar 23, 2023
@AlexWaygood
AlexWaygood merged commit b613208 into python:mainMar 23, 2023
@miss-islington

miss-islington commented Mar 23, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 23, 2023
@sobolevn@miss-islington
pythongh-98239: Document thatinspect.getsource()can raise `TypeEr…
79cd865
…ror` (pythonGH-101689)
(cherry picked from commit b613208)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot

bedevere-bot commented Mar 23, 2023

Copy link
Copy Markdown

GH-102969 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Mar 23, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 23, 2023
@sobolevn@miss-islington
pythongh-98239: Document thatinspect.getsource()can raise `TypeEr…
e395b9a
…ror` (pythonGH-101689)
(cherry picked from commit b613208)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot

bedevere-bot commented Mar 23, 2023

Copy link
Copy Markdown

GH-102970 is a backport of this pull request to the 3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Mar 23, 2023
miss-islington added a commit that referenced this pull request Mar 23, 2023
@miss-islington@sobolevn
gh-98239: Document thatinspect.getsource()can raiseTypeError(G…
77e54fe
…H-101689)
(cherry picked from commit b613208)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull request Mar 23, 2023
@miss-islington@sobolevn
gh-98239: Document thatinspect.getsource()can raiseTypeError(G…
202e16e
…H-101689)
(cherry picked from commit b613208)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
@sobolevn@Fidget-Spinner
pythongh-98239: Document thatinspect.getsource()can raise `TypeEr…
c25402d
…ror` (python#101689)
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@sobolevn@warsaw
pythongh-98239: Document thatinspect.getsource()can raise `TypeEr…
280960c
…ror` (python#101689)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn@miss-islington@bedevere-bot@AlexWaygood