Uh oh!
There was an error while loading. Please reload this page.
gh-101865: Deprecate co_lnotab from code objects as per PEP 626 - #101866
Conversation
sobolevn
commented
Feb 13, 2023
I've pushed my naive attempt to fix |
sobolevn
commented
Feb 21, 2023
@markshannon friendly ping :) |
…cts as per PEP626" This reverts commit 06a79d9.
co_lnotab from code objects as per PEP626co_lnotab from code objects as per PEP626Failures do not seem related 🤔 |
|
sobolevn
commented
Mar 11, 2023
@markshannon do you have time to re-review this, please? :) |
@carljm maybe you can have a look? :) |
markshannon
left a comment
There was a problem hiding this comment.
Looks good in general.
We aren't obliged to remove co_lnotab in 3.14, but we can. Perhaps change the "will"s to "may"s.
Not sure what to do about Misc/gdbinit though.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
markshannon
commented
Mar 18, 2023
Perhaps we should discuss the future of Misc/gdbinit in another issue, and not worry about it here. |
sobolevn
commented
Mar 18, 2023
@markshannon thanks a lot for your review and for all your hard work on CPython!
|
hugovk
commented
Mar 18, 2023
Shall we add a |
co_lnotab from code objects as per PEP626co_lnotab from code objects as per PEP 626I think that we can add "is deprecated since 3.12 and may be removed in 3.14". |
hugovk
commented
Mar 19, 2023
Sure, let's do something like that. |
sobolevn
commented
Mar 21, 2023
|
sobolevn
commented
Apr 3, 2023
@markshannon I've solved the merge conflicts. I hope that this is ready to be merged when you have the time :) |
…26 (python#101866) Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
…26 (python#101866) Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
I still have to fix these lines:
cpython/Misc/gdbinit
Lines 60 to 61 in 6ef6915
But, since I have 0 experience with
gdbit might take some time.co_lnotabmust be removed in 3.12 according to PEP 626 #101865