Uh oh!
There was an error while loading. Please reload this page.
gh-99108: Build the hashlib HACL* code as a static library. (fix wasm builds) - #101917
Conversation
gpshead
commented
Feb 14, 2023
!buildbot wasm |
bedevere-bot
commented
Feb 14, 2023
🤖 New build scheduled with the buildbot fleet by @gpshead for commit 3c7e18e 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
gpshead
commented
Feb 14, 2023
The wasm-wasi bot using llvm-ar to build libpython3.12.a appears happy with this. |
is this the problem? the .a file is showing up on the emcc linking command line twice, is that really the source of the "duplicate" symbols? is emcc that dumb?
gpshead
commented
Feb 14, 2023
!buildbot wasm |
bedevere-bot
commented
Feb 14, 2023
🤖 New build scheduled with the buildbot fleet by @gpshead for commit a5bb63e 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
gpshead
commented
Feb 14, 2023
Emscripten Real linkers (like clang and thus llvm's ld.lld) do not have a problem with this. |
gpshead
commented
Feb 14, 2023
Realistically: We should probably just combine |
gpshead
commented
Feb 14, 2023
I'll do that as its own follow on PR. This one at least addresses 2 of the 4 bot failures and defines the static library as we want regardless. |
A followup to #101707 which broke some builds. This builds HACL* as a library in one place.
This doesn't solve all the problems, the wasm-wasi build is fixed by this. The wasm-enscripten build is not. Because it has a linker that can't cope with the same .a file being listed twice on its command line and decides to ignorantly process that as two inputs with duplicate symbols.