Skip to content

gh-101981: Update macOS workflow - #101991

Closed
corona10 wants to merge 4 commits into
python:mainfrom
corona10:mac_os_fix
Closed

gh-101981: Update macOS workflow#101991
corona10 wants to merge 4 commits into
python:mainfrom
corona10:mac_os_fix

Conversation

@corona10

@corona10corona10 commented Feb 17, 2023

Copy link
Copy Markdown
Member

@corona10
corona10force-pushed the mac_os_fix branch 7 times, most recently from 7677da1 to c170ccaCompareFebruary 17, 2023 15:53
@corona10corona10 changed the title .github: Update macOS openSSL configurationgh-101981: Update macOS workflowFeb 17, 2023
@corona10
corona10 marked this pull request as ready for review February 17, 2023 15:54
Comment thread.github/workflows/build.yml Outdated
brew install pkg-config openssl@1.1 xz gdbm tcl-tk
echo "CFLAGS=-I$(brew --prefix gdbm)/include -I$(brew --prefix xz)/include" >> $GITHUB_ENV
echo "LDFLAGS=-L$(brew --prefix gdbm)/lib -I$(brew --prefix xz)/lib" >> $GITHUB_ENV
echo "PKG_CONFIG_PATH=$(brew --prefix tcl-tk)/lib/pkgconfig" >> $GITHUB_ENV

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not follow the devguide recipe and use one shell line? Those variables should only be needed for the configure command

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ned-deily

@ned-deilyned-deilyFeb 17, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the devguide recipe does not consist of multiple commands on multiple lines as in that link, i.e. it's not "in the form of an output from one step, and an input to another step". It's a single shell command that has been split across lines in the devguide for readability and it doesn't need to be. (The POSIX command language standard calls it a "simple command": "A simple command is a sequence of optional variable assignments and redirections, in any sequence, optionally followed by words and redirections, terminated by a control operator." There is no piping involved here.)

@bedevere-bot

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@corona10

Copy link
Copy Markdown
MemberAuthor

I have made the requested changes; please review again

I am thinking about how to resolve test_freeze_simple_script

@corona10corona10 changed the title gh-101981: Update macOS workflow[WIP] gh-101981: Update macOS workflowFeb 18, 2023
@corona10
corona10force-pushed the mac_os_fix branch 2 times, most recently from 8c3019e to 28c8fa3CompareFebruary 18, 2023 06:30
@corona10
corona10force-pushed the mac_os_fix branch 2 times, most recently from ce7ba2e to 28c8fa3CompareFebruary 18, 2023 07:42
@corona10corona10 reopened this Feb 18, 2023
@corona10corona10 changed the title [WIP] gh-101981: Update macOS workflowgh-101981: Update macOS workflowFeb 18, 2023
@corona10

Copy link
Copy Markdown
MemberAuthor

I have made the requested changes; please review again

@bedevere-bot

Copy link
Copy Markdown

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@corona10@bedevere-bot@ned-deily