Add missing 'is' to `cmath.log()` docstring by OTheDev · Pull Request #102049 · python/cpython

OTheDev · 2023-02-19T13:35:46Z

No description provided.

mdickinson

LGTM!

OTheDev · 2023-02-19T14:02:01Z

Thanks!

mdickinson · 2023-02-19T15:00:38Z

One buildbot failure with no plausible connection to this PR.

bedevere-bot · 2023-02-19T15:13:25Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.x has failed when building commit 71f614e.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/725/builds/3776) and take a look at the build logs.
Check if the failure is related to this commit (71f614e) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/725/builds/3776

Failed tests:

test_asyncio

Failed subtests:

test_wait_for_race_condition - test.test_asyncio.test_waitfor.AsyncioWaitForTest.test_wait_for_race_condition

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

405 tests OK.

10 slowest tests:

test_signal: 4 min 34 sec
test_concurrent_futures: 2 min 34 sec
test_multiprocessing_spawn: 2 min 5 sec
test_ssl: 1 min 45 sec
test_multiprocessing_forkserver: 1 min 38 sec
test_asyncio: 1 min 34 sec
test_math: 1 min 10 sec
test_logging: 1 min 5 sec
test_capi: 48.0 sec
test_tokenize: 39.1 sec

1 test failed:
test_asyncio

25 tests skipped:
test_check_c_globals test_devpoll test_epoll test_gdb test_idle
test_ioctl test_launcher test_msilib test_multiprocessing_fork
test_ossaudiodev test_peg_generator test_perf_profiler test_spwd
test_startfile test_tcl test_tix test_tkinter test_ttk
test_ttk_textonly test_turtle test_winconsoleio test_winreg
test_winsound test_wmi test_zipfile64

1 re-run test:
test_asyncio

Total duration: 9 min 21 sec

Click to see traceback logs

Traceback (most recent call last):
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncio/tasks.py", line 478, in wait_forreturnawait fut
^^^^^^^^^
asyncio.exceptions.CancelledError
Traceback (most recent call last):
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/unittest/async_case.py", line 90, in _callTestMethodifself._callMaybeAsync(method) isnotNone:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/unittest/async_case.py", line 112, in _callMaybeAsyncreturnself._asyncioRunner.run(
^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncio/runners.py", line 118, in runreturnself._loop.run_until_complete(task)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncio/base_events.py", line 664, in run_until_completereturn future.result()
^^^^^^^^^^^^^^^
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_asyncio/test_waitfor.py", line 163, in test_wait_for_race_condition
res =await task
^^^^^^^^^^
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncio/tasks.py", line 477, in wait_forasyncwith timeouts.timeout(timeout):
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncio/timeouts.py", line 98, in __aexit__raiseTimeoutError
TimeoutError

* main: (60 commits) pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078) pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012) pythongh-101566: Sync with zipp 3.14. (pythonGH-102018) pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589) pythongh-88233: zipfile: handle extras after a zip64 extra (pythonGH-96161) pythongh-101981: Apply HOMEBREW related environment variables (pythongh-102074) pythongh-101907: Stop using `_Py_OPCODE` and `_Py_OPARG` macros (pythonGH-101912) pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949) pythongh-101981: Build macOS as recommended by the devguide (pythonGH-102070) pythongh-97786: Fix compiler warnings in pytime.c (python#101826) pythongh-101578: Amend PyErr_{Set,Get}RaisedException docs (python#101962) Misc improvements to the float tutorial (pythonGH-102052) pythongh-85417: Clarify behaviour on branch cuts in cmath module (python#102046) pythongh-100425: Update tutorial docs related to sum() accuracy (FH-101854) Add missing 'is' to `cmath.log()` docstring (python#102049) pythongh-100210: Correct the comment link for unescaping HTML (python#100212) pythongh-97930: Also include subdirectory in makefile. (python#102030) pythongh-99735: Use required=True in argparse subparsers example (python#100927) Fix incorrectly documented attribute in csv docs (python#101250) pythonGH-84783: Make the slice object hashable (pythonGH-101264) ...

* main: (225 commits) pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078) pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012) pythongh-101566: Sync with zipp 3.14. (pythonGH-102018) pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589) pythongh-88233: zipfile: handle extras after a zip64 extra (pythonGH-96161) pythongh-101981: Apply HOMEBREW related environment variables (pythongh-102074) pythongh-101907: Stop using `_Py_OPCODE` and `_Py_OPARG` macros (pythonGH-101912) pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949) pythongh-101981: Build macOS as recommended by the devguide (pythonGH-102070) pythongh-97786: Fix compiler warnings in pytime.c (python#101826) pythongh-101578: Amend PyErr_{Set,Get}RaisedException docs (python#101962) Misc improvements to the float tutorial (pythonGH-102052) pythongh-85417: Clarify behaviour on branch cuts in cmath module (python#102046) pythongh-100425: Update tutorial docs related to sum() accuracy (FH-101854) Add missing 'is' to `cmath.log()` docstring (python#102049) pythongh-100210: Correct the comment link for unescaping HTML (python#100212) pythongh-97930: Also include subdirectory in makefile. (python#102030) pythongh-99735: Use required=True in argparse subparsers example (python#100927) Fix incorrectly documented attribute in csv docs (python#101250) pythonGH-84783: Make the slice object hashable (pythonGH-101264) ...

miss-islington · 2023-02-26T13:22:39Z

Thanks @OTheDev for the PR, and @mdickinson for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington · 2023-02-26T13:22:39Z

Thanks @OTheDev for the PR, and @mdickinson for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington · 2023-02-26T13:22:42Z

Sorry, @OTheDev and @mdickinson, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 71f614ef2a3d66213b9cae807cbbc1ed03741221 3.10

miss-islington · 2023-02-26T13:22:44Z

Sorry @OTheDev and @mdickinson, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 71f614ef2a3d66213b9cae807cbbc1ed03741221 3.11

mdickinson · 2023-02-26T13:24:03Z

Gah. The backports are going to get hung up on the argument clinic hashes, of course.

Fix missing 'is' in cmath.log() docstring. (cherry picked from commit 71f614e) Co-authored-by: Owain Davies <116417456+OTheDev@users.noreply.github.com>

bedevere-bot · 2023-02-26T13:32:14Z

GH-102279 is a backport of this pull request to the 3.11 branch.

bedevere-bot · 2023-02-26T13:33:50Z

GH-102280 is a backport of this pull request to the 3.10 branch.

OTheDev · 2023-02-26T13:35:37Z

Sorry, I've only just noticed that there were issues with the backports!

OTheDev · 2023-02-26T13:35:49Z

Thanks a lot!

mdickinson · 2023-02-26T13:38:09Z

I've only just noticed that there were issues with the backports!

That's because I only just got around to actually trying to backport. :-)

Fix missing 'is' in cmath.log() docstring. (cherry picked from commit 71f614e) Co-authored-by: Owain Davies <116417456+OTheDev@users.noreply.github.com>

Fix missing 'is' in cmath.log() docstring
ef765ca

bedevere-bot added the awaiting review label Feb 19, 2023

mdickinson added skip issue skip news labels Feb 19, 2023

mdickinson approved these changes Feb 19, 2023
View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Feb 19, 2023

mdickinson merged commit 71f614e into python:mainFeb 19, 2023

bedevere-bot removed the awaiting merge label Feb 19, 2023

mdickinson added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Feb 26, 2023

miss-islington assigned mdickinson Feb 26, 2023

bedevere-bot removed the needs backport to 3.11 only security fixes label Feb 26, 2023

bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 26, 2023

OTheDev deleted the fix-cmath-log-docstring branch January 28, 2025 03:58

Uh oh!

Uh oh!

Conversation

OTheDev commented Feb 19, 2023

Uh oh!

mdickinson left a comment

Choose a reason for hiding this comment

Uh oh!

OTheDev commented Feb 19, 2023

Uh oh!

mdickinson commented Feb 19, 2023

Uh oh!

bedevere-bot commented Feb 19, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

miss-islington commented Feb 26, 2023

Uh oh!

miss-islington commented Feb 26, 2023

Uh oh!

miss-islington commented Feb 26, 2023

Uh oh!

miss-islington commented Feb 26, 2023

Uh oh!

mdickinson commented Feb 26, 2023

Uh oh!

bedevere-bot commented Feb 26, 2023

Uh oh!

bedevere-bot commented Feb 26, 2023

Uh oh!

OTheDev commented Feb 26, 2023

Uh oh!

OTheDev commented Feb 26, 2023

Uh oh!

mdickinson commented Feb 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants