Uh oh!
There was an error while loading. Please reload this page.
[3.10] gh-101981: Build macOS as recommended by the devguide (GH-102070) - #102073
Merged
Merged
Conversation
This was referenced Feb 20, 2023
erlend-aasland
approved these changes
Feb 20, 2023
erlend-aasland
commented
Feb 20, 2023
Contributor
corona10
commented
Feb 20, 2023
Member
|
Member
Re-run the job?, I would like to check if this is a temporal issue or not. |
corona10
commented
Feb 20, 2023
Member
Ah okay.. |
hugovk
commented
Feb 20, 2023
Member
It's a failing Ubuntu job, so unrelated to this PR. |
hugovk
approved these changes
Feb 20, 2023
Member
+1, Should be solved by a separate issue. |
corona10
approved these changes
Feb 20, 2023
erlend-aasland
commented
Feb 20, 2023
Contributor
cc. @pablogsal as RM for Python 3.10; see comments about failing CI. Are you fine with me landing this? |
Member
Thanks for checking with me! This looks good to me but I am not sure what comment are your referring to about failing CI. It seems that the issue in the CI was transient/unrelated, no? |
hugovk
commented
Feb 20, 2023
Member
Yes, unrelated, and also failing on a clean https://github.com/hugovk/cpython/actions/runs/4224278452/jobs/7335046068 |
corona10
commented
Feb 20, 2023
Member
See how to fix it: #102079 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 2713631)
Co-authored-by: Erlend E. Aasland erlend.aasland@protonmail.com
Automerge-Triggered-By: GH:erlend-aasland