Uh oh!
There was an error while loading. Please reload this page.
gh-88233: zipfile: refactor _strip_extra - #102084
Merged
Merged
Conversation
jaracoforce-pushed
the
refactor/zipfile-extra
branch
from
February 20, 2023 16:57
13f4fad to
6ebff4aComparejaracoforce-pushed
the
refactor/zipfile-extra
branch
from
February 20, 2023 17:10
6e57d1f to
e6abc55Comparejaraco
commented
Feb 25, 2023
Uh oh!
There was an error while loading. Please reload this page.
jaraco
commented
Jul 14, 2023
MemberAuthor
@serhiy-storchaka If you don't mind, would you take a look at this refactor - see if you have any concerns? |
bedevere-bot
commented
Sep 25, 2023
|
csm10495 pushed a commit
to csm10495/cpython
that referenced
this pull request
Sep 28, 2023
* Refactor zipfile._strip_extra to use higher level abstractions for extras instead of a heavy-state loop. * Add blurb * Remove _strip_extra and use _Extra.strip directly. * Use memoryview to avoid unnecessary copies while splitting Extras.
Glyphack pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
* Refactor zipfile._strip_extra to use higher level abstractions for extras instead of a heavy-state loop. * Add blurb * Remove _strip_extra and use _Extra.strip directly. * Use memoryview to avoid unnecessary copies while splitting Extras.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing #96161, I too had difficulty fully understanding the complexities of
_strip_extrafunction.This PR refactors that function to use a class with methods separating the concerns (parsing, splitting, filtering, modeling) and using a higher-level abstraction to model the concept.