Uh oh!
There was an error while loading. Please reload this page.
gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Modules/) - #102196
Merged
Merged
Conversation
iritkatriel
requested review from
1st1, asvetlov, berkerpeksag, erlend-aasland, gvanrossum and kumaraditya303
as code ownersFebruary 24, 2023 00:48
erlend-aasland
approved these changes
Feb 24, 2023
bedevere-bot
commented
Feb 24, 2023
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 04985db 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
commented
Feb 24, 2023
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 6798b05 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
kumaraditya303
approved these changes
Feb 24, 2023
kumaraditya303
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Short on time so only reviewing asyncio changes.
erlend-aasland
commented
Feb 24, 2023
Contributor
FTR, I've looked over the rest. |
JelleZijlstra pushed a commit
to JelleZijlstra/cpython
that referenced
this pull request
Sep 10, 2024
…ternatives (in Modules/) (python#102196)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes most of the PyErr_Fetch in Modules/. I left out a few which are a little more complicated.