Skip to content

gh-102281: fix potential nullptr dereference + use of uninitialized memory - #102282

Merged
corona10 merged 3 commits into
python:mainfrom
maxbachmann:patch-7
Mar 15, 2023
Merged

gh-102281: fix potential nullptr dereference + use of uninitialized memory#102282
corona10 merged 3 commits into
python:mainfrom
maxbachmann:patch-7

Conversation

@maxbachmann

@maxbachmannmaxbachmann commented Feb 26, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-botbedevere-bot mentioned this pull request Feb 26, 2023
Closed
maxbachmann
maxbachmann commented Feb 26, 2023
View reviewed changes
Comment threadPython/fileutils.c Outdated
@arhadthedev

arhadthedev commented Mar 4, 2023

Copy link
Copy Markdown
Member

@vstinner (as a frequent committer into Python/fileutils.c)

@arhadthedevarhadthedev added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Mar 4, 2023
corona10
corona10 requested changes Mar 14, 2023
View reviewed changes
Comment threadPython/fileutils.c Outdated
@bedevere-bot

bedevere-bot commented Mar 14, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@corona10corona10 self-assigned this Mar 14, 2023
corona10
corona10 reviewed Mar 15, 2023
View reviewed changes
Comment threadModules/getpath.c
corona10
corona10 approved these changes Mar 15, 2023
View reviewed changes

@corona10corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corona10
corona10 merged commit afa6092 into python:mainMar 15, 2023
@corona10corona10 added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Mar 15, 2023
@miss-islington

miss-islington commented Mar 15, 2023

Copy link
Copy Markdown
Contributor

Thanks @maxbachmann for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Mar 15, 2023

Copy link
Copy Markdown
Contributor

Thanks @maxbachmann for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Mar 15, 2023

Copy link
Copy Markdown
Contributor

Sorry, @maxbachmann and @corona10, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker afa6092ee4260bacf7bc11905466e4c3f8556cbb 3.10

@miss-islington

miss-islington commented Mar 15, 2023

Copy link
Copy Markdown
Contributor

Sorry @maxbachmann and @corona10, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker afa6092ee4260bacf7bc11905466e4c3f8556cbb 3.11

@maxbachmann

maxbachmann commented Mar 15, 2023

Copy link
Copy Markdown
ContributorAuthor

@corona10 will you do the backporting, or should I create the corresponding Pull Requests?

@corona10

corona10 commented Mar 15, 2023

Copy link
Copy Markdown
Member

@corona10 will you do the backporting, or should I create the corresponding Pull Requests?

Please create PRs for them :)

@maxbachmannmaxbachmann mentioned this pull request Mar 25, 2023
Merged
@bedevere-bot

bedevere-bot commented Mar 25, 2023

Copy link
Copy Markdown

GH-103040 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Mar 25, 2023
@maxbachmann

maxbachmann commented Mar 25, 2023

Copy link
Copy Markdown
ContributorAuthor

@corona10 This does not need a backport for Python 3.10, since this issue was introduced in Python 3.11.

@hauntsaninjahauntsaninja removed the needs backport to 3.10 only security fixes label Mar 25, 2023
hauntsaninja pushed a commit that referenced this pull request Mar 25, 2023
@maxbachmann
[3.11]gh-102281: Fix potential nullptr dereference + use of uninitia… (
b28f919
#103040)
[3.11] gh-102281: Fix potential nullptr dereference + use of uninitialized memory (gh-102282)
(cherry picked from commit afa6092)
@maxbachmann
maxbachmann deleted the patch-7 branch March 26, 2023 00:34
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
@maxbachmann@Fidget-Spinner
pythongh-102281: Fix potential nullptr dereference + use of uninitial…
06915ed
…ized memory (pythongh-102282)
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@maxbachmann@warsaw
pythongh-102281: Fix potential nullptr dereference + use of uninitial…
8d154eb
…ized memory (pythongh-102282)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10corona10corona10 approved these changes

Assignees

@corona10corona10

Labels

interpreter-core(Objects, Python, Grammar, and Parser dirs)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@maxbachmann@arhadthedev@bedevere-bot@miss-islington@corona10@hauntsaninja