Uh oh!
There was an error while loading. Please reload this page.
gh-98831: Use DECREF_INPUTS() more - #102409
Merged
Merged
Conversation
gvanrossum
commented
Mar 4, 2023
MemberAuthor
Hm, there are refleaks. |
gvanrossumforce-pushed
the
more-decref-inputs
branch
from
March 13, 2023 20:20
394f2e0 to
dc507f4CompareAlso convert END_FOR (the only macro inst) to a regular inst.
gvanrossumforce-pushed
the
more-decref-inputs
branch
from
March 13, 2023 20:23
dc507f4 to
12e85cfComparegvanrossum
marked this pull request as ready for review
March 13, 2023 20:23
bedevere-bot
commented
Mar 13, 2023
🤖 New build scheduled with the buildbot fleet by @gvanrossum for commit 12e85cf 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
gvanrossum
commented
Mar 13, 2023
MemberAuthor
@iritkatriel Even if there is still a refleak it would be nice to have a second pair of eyes on this. |
iritkatriel
approved these changes
Mar 13, 2023
iritkatriel
left a comment
Member
There was a problem hiding this comment.
The diff in the generated file is quite small, and seems fine.
carljm added a commit
to carljm/cpython
that referenced
this pull request
Mar 14, 2023
* main: (50 commits) pythongh-102674: Remove _specialization_stats from Lib/opcode.py (python#102685) pythongh-102660: Handle m_copy Specially for the sys and builtins Modules (pythongh-102661) pythongh-102354: change python3 to python in docs examples (python#102696) pythongh-81057: Add a CI Check for New Unsupported C Global Variables (pythongh-102506) pythonGH-94851: check unicode consistency of static strings in debug mode (python#102684) pythongh-100315: clarification to `__slots__` docs. (python#102621) pythonGH-100227: cleanup initialization of global interned dict (python#102682) doc: Remove a duplicate 'versionchanged' in library/asyncio-task (pythongh-102677) pythongh-102013: Add PyUnstable_GC_VisitObjects (python#102014) pythonGH-102670: Use sumprod() to simplify, speed up, and improve accuracy of statistics functions (pythonGH-102649) pythongh-102627: Replace address pointing toward malicious web page (python#102630) pythongh-98831: Use DECREF_INPUTS() more (python#102409) pythongh-101659: Avoid Allocation for Shared Exceptions in the _xxsubinterpreters Module (pythongh-102659) pythongh-101524: Fix the ChannelID tp_name (pythongh-102655) pythongh-102069: Fix `__weakref__` descriptor generation for custom dataclasses (python#102075) pythongh-98169 dataclasses.astuple support DefaultDict (python#98170) pythongh-102650: Remove duplicate include directives from multiple source files (python#102651) pythonGH-100987: Don't cache references to the names and consts array in `_PyEval_EvalFrameDefault`. (python#102640) pythongh-87092: refactor assemble() to a number of separate functions, which do not need the compiler struct (python#102562) pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (python#102631) ...
Fidget-Spinner pushed a commit
to Fidget-Spinner/cpython
that referenced
this pull request
Mar 27, 2023
warsaw pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helped with the tagged refcount project (anything done here doesn't need to be done manually), and might help with future similar projects.