Uh oh!
There was an error while loading. Please reload this page.
Remove unused internal macros - #102415
Conversation
mdickinson
commented
Mar 4, 2023
For more context, see the discussion in #17933 |
mdickinson
commented
Mar 4, 2023
@corona10@kumaraditya303 Thanks for the reviews! |
bedevere-bot
commented
Mar 4, 2023
|
Since python#101826 was merged, the internal macro `_Py_InIntegralTypeRange` is unused, as are its supporting macros `_Py_IntegralTypeMax` and `_Py_IntegralTypeMin`. This PR removes them. Note that `_Py_InIntegralTypeRange` doesn't actually work as advertised - it's not a safe way to avoid undefined behaviour in an integer to double conversion.
vstinner
commented
Apr 5, 2023
Thanks for removing these macros :-) |
Since #101826, the internal macro
_Py_InIntegralTypeRangeis unused, as are its supporting macros_Py_IntegralTypeMaxand_Py_IntegralTypeMin. This PR removes them.Note that
_Py_InIntegralTypeRangedoesn't actually work as advertised - it's not a safe way to avoid undefined behaviour in an integer to double conversion.