Skip to content

gh-102515: Remove unused imports in the Lib/ directory - #102516

Merged
pablogsal merged 4 commits into
python:mainfrom
AlexWaygood:unused-imports
Mar 8, 2023
Merged

gh-102515: Remove unused imports in the Lib/ directory#102516
pablogsal merged 4 commits into
python:mainfrom
AlexWaygood:unused-imports

Conversation

@AlexWaygood

@AlexWaygoodAlexWaygood commented Mar 7, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Identified using the pycln tool; manually reviewed by me.

@bedevere-botbedevere-bot mentioned this pull request Mar 7, 2023
Closed
@AlexWaygoodAlexWaygood added skip news stdlib Standard Library Python modules in the Lib/ directory labels Mar 7, 2023
gvanrossum
gvanrossum reviewed Mar 7, 2023
View reviewed changes
Comment threadLib/concurrent/futures/process.py
Comment threadLib/multiprocessing/queues.py
Comment threadLib/test/test_asyncio/test_ssl.py
Comment threadLib/test/test_peg_generator/test_c_parser.py
@hugovk

hugovk commented Mar 7, 2023

Copy link
Copy Markdown
Member

Maybe worth commenting some of the less-obvious, required imports for next time?

@terryjreedy

terryjreedy commented Mar 7, 2023

Copy link
Copy Markdown
Member

Of the 34 files with 'extra' imports, 28 are in test. If the tests pass, we may assume that the deletions are really unused. I am checking the deletions in regular code and already found an error.

@terryjreedy

terryjreedy commented Mar 7, 2023

Copy link
Copy Markdown
Member

Guido refuted my comment about not checking tests, and found the issue with multliprocessing.connection. I consider that to be a bug in pycln.

@terryjreedyterryjreedy reopened this Mar 7, 2023
@AlexWaygood

AlexWaygood commented Mar 7, 2023

Copy link
Copy Markdown
MemberAuthor

I consider that to be a bug in pycln.

It's an imperfect tool, and the stdlib is possibly the worst kind of code to judge it on. I've had good experiences with using the tool on other projects, but if you simply run pycln Lib --all in the CPython repo, it removes 290 imports from 150 files. Most of these are false positives.

gvanrossum
gvanrossum reviewed Mar 7, 2023
View reviewed changes
Comment threadLib/multiprocessing/queues.py
@rhettinger
rhettinger removed their request for review March 8, 2023 02:49
@pablogsal
pablogsal merged commit 401d7a7 into python:mainMar 8, 2023
@AlexWaygood
AlexWaygood deleted the unused-imports branch March 8, 2023 11:47
@AlexWaygood

AlexWaygood commented Mar 8, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Thanks @gvanrossum, @terryjreedy and @kumaraditya303 for the careful reviews! Much appreciated.

carljm added a commit to carljm/cpython that referenced this pull request Mar 8, 2023
@carljm
Merge branch 'main' into inlinecomp2
06db319
* main:
pythongh-102304: Consolidate Direct Usage of _Py_RefTotal (pythongh-102514)
pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Objects/) (python#102218)
pythongh-102507 Remove invisible pagebreak characters (python#102531)
pythongh-102515: Remove unused imports in the `Lib/` directory (python#102516)
Remove or update bitbucket links (pythonGH-101963)
pythongh-101100: Fix sphinx warnings in `zipapp` and `zipfile` modules (python#102526)
pythonGH-102397: Fix segfault from race condition in signal handling (python#102399)
Fix style in argparse.rst (python#101733)
Post 3.12.0a6
fix typo in async generator code field name `ag_code` (python#102448)
Python 3.12.0a6
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes
@FFY00FFY00FFY00 approved these changes
@kumaraditya303kumaraditya303kumaraditya303 approved these changes
@ethanfurmanethanfurmanAwaiting requested review from ethanfurmanethanfurman is a code owner
@ericvsmithericvsmithAwaiting requested review from ericvsmithericvsmith is a code owner
@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner
@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner
@vsajipvsajipAwaiting requested review from vsajipvsajip is a code owner
@tirantiranAwaiting requested review from tiran
@iritkatrieliritkatrielAwaiting requested review from iritkatriel
@1st11st1Awaiting requested review from 1st11st1 is a code owner
@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

Assignees

No one assigned

Labels

skip newsstdlibStandard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unused imports in the Lib/ directory

8 participants

@AlexWaygood@hugovk@terryjreedy@gvanrossum@FFY00@kumaraditya303@pablogsal@bedevere-bot