Skip to content

gh-102500: Implement PEP 688 - #102521

Merged
JelleZijlstra merged 51 commits into
python:mainfrom
JelleZijlstra:pep688v2
May 4, 2023
Merged

gh-102500: Implement PEP 688#102521
JelleZijlstra merged 51 commits into
python:mainfrom
JelleZijlstra:pep688v2

Conversation

@JelleZijlstra

@JelleZijlstraJelleZijlstra commented Mar 8, 2023•
edited
Loading

Copy link
Copy Markdown
Member

This PR implements only the code changes for the PEP; documentation will be added separately.

Example:

>>> memoryview(b"x", flags=inspect.BufferFlags.WRITABLE)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
BufferError: Object is not writable.
>>> memoryview(b"x", flags=inspect.BufferFlags.SIMPLE)
<memory at 0x103391640>

@JelleZijlstra
try 1
ca76251
@JelleZijlstra
progress
901b459
@JelleZijlstra
this is better
c5407c7
@JelleZijlstra
this seems to work
86f2000
@JelleZijlstra
one more test
ac10887
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into pep688v2
2563016
@JelleZijlstra
additions
530a160
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into pep688v2
de3a4bc
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into pep688v2
116f72e
@JelleZijlstra
introduce __mutable_buffer__ (rather hackily)
207d2fd
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into pep688v2
aee2c33
@JelleZijlstra
Rip out __mutable_buffer__
007fdc1
@JelleZijlstra
__release_buffer__ calls mv.release()
46a9239
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into pep688v2
3020fee
@JelleZijlstra
additional test
be9bf45
@JelleZijlstra
undo stray change
a6bf0e8
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into pep688v2
04d267e
@JelleZijlstra
throw an error if already released
04d0a42
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into pep688v2
bb6d076
@JelleZijlstra
Fix compiler warning
5f755fe
@JelleZijlstra
news
0b02e63
@bedevere-botbedevere-bot mentioned this pull request Mar 8, 2023
Closed
sobolevn
sobolevn reviewed Mar 8, 2023
View reviewed changes

@sobolevnsobolevn left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am always happy when typing-related work is used for better APIs! Thank you 🎉

Comment threadModules/_testcapimodule.c Outdated
Comment threadLib/inspect.py
Comment threadLib/test/test_buffer.py
@JelleZijlstra
JelleZijlstra requested a review from a team as a code ownerMarch 10, 2023 04:58
kumaraditya303
kumaraditya303 reviewed May 4, 2023
View reviewed changes
Comment threadLib/test/test_buffer.py
Comment threadObjects/memoryobject.c Outdated
@kumaraditya303

kumaraditya303 commented May 4, 2023

Copy link
Copy Markdown
Contributor

@JelleZijlstra I pushed some fixes directly, hope you don't mind it. See my review comments, especially the one for typeobject.

kumaraditya303
kumaraditya303 requested changes May 4, 2023
View reviewed changes
Comment threadObjects/typeobject.c
@bedevere-bot

bedevere-bot commented May 4, 2023

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@JelleZijlstra

JelleZijlstra commented May 4, 2023

Copy link
Copy Markdown
MemberAuthor

Thanks Kumar for the review and fixes!

I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented May 4, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@hauntsaninja, @kumaraditya303: please review the changes made to this pull request.

kumaraditya303
kumaraditya303 reviewed May 4, 2023
View reviewed changes
Comment threadObjects/typeobject.c Outdated
@JelleZijlstra

JelleZijlstra commented May 4, 2023

Copy link
Copy Markdown
MemberAuthor

Seems like I need to run regen-all, doing that.

kumaraditya303
kumaraditya303 approved these changes May 4, 2023
View reviewed changes

@kumaraditya303kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JelleZijlstra
JelleZijlstra merged commit 04f6733 into python:mainMay 4, 2023
@JelleZijlstra
JelleZijlstra deleted the pep688v2 branch May 4, 2023 14:59
carljm added a commit to carljm/cpython that referenced this pull request May 5, 2023
@carljm
Merge branch 'main' into inlinecomp2
8a78a36
* main: (61 commits)
pythongh-64595: Argument Clinic: Touch source file if any output file changed (python#104152)
pythongh-64631: Test exception messages in cloned Argument Clinic funcs (python#104167)
pythongh-68395: Avoid naming conflicts by mangling variable names in Argument Clinic (python#104065)
pythongh-64658: Expand Argument Clinic return converter docs (python#104175)
pythonGH-103092: port `_asyncio` freelist to module state (python#104196)
pythongh-104051: fix crash in test_xxtestfuzz with -We (python#104052)
pythongh-104190: fix ubsan crash (python#104191)
pythongh-104106: Add gcc fallback of mkfifoat/mknodat for macOS (pythongh-104129)
pythonGH-104142: Fix _Py_RefcntAdd to respect immortality (pythonGH-104143)
pythongh-104112: link from cached_property docs to method-caching FAQ (python#104113)
pythongh-68968: Correcting message display issue with assertEqual (python#103937)
pythonGH-103899: Provide a hint when accidentally calling a module (pythonGH-103900)
pythongh-103963: fix 'make regen-opcode' in out-of-tree builds (python#104177)
pythongh-102500: Add PEP 688 and 698 to the 3.12 release highlights (python#104174)
pythonGH-81079: Add case_sensitive argument to `pathlib.Path.glob()` (pythonGH-102710)
pythongh-91896: Deprecate collections.abc.ByteString (python#102096)
pythongh-99593: Add tests for Unicode C API (part 2) (python#99868)
pythongh-102500: Document PEP 688 (python#102571)
pythongh-102500: Implement PEP 688 (python#102521)
pythongh-96534: socketmodule: support FreeBSD divert(4) socket (python#96536)
...
sunmy2019
sunmy2019 reviewed Jun 4, 2023
View reviewed changes
Comment threadObjects/typeobject.c
@JelleZijlstra
JelleZijlstra restored the pep688v2 branch September 10, 2024 23:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrentlyericsnowcurrentlyericsnowcurrently left review comments
@sobolevnsobolevnsobolevn left review comments
@sunmy2019sunmy2019sunmy2019 left review comments
@kumaraditya303kumaraditya303kumaraditya303 approved these changes
@encukouencukouAwaiting requested review from encukou
@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner
@hauntsaninjahauntsaninjaAwaiting requested review from hauntsaninja
+1 more reviewer
@TeamSpen210TeamSpen210TeamSpen210 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@JelleZijlstra@rhettinger@arhadthedev@ericsnowcurrently@bedevere-bot@kumaraditya303@sobolevn@TeamSpen210@hauntsaninja@sunmy2019