Uh oh!
There was an error while loading. Please reload this page.
bpo-35081: Move _PyObject_GC_TRACK() to pycore_object.h - #10276
Closed
vstinner wants to merge 1 commit into
Closed
Conversation
vstinner
commented
Nov 1, 2018
MemberAuthor
Without that, at least 33 C files has to be modified to add include pycore_object.h: see my first attempt, PR #10272. I prefer to have smaller PR, easier to review. The automatic include can be removed later. |
vstinner
commented
Nov 1, 2018
MemberAuthor
Note for myself: PR #10275 has to be updated if this PR is merged before. |
* Create Include/internal/pycore_object.h * Move _PyObject_GC_TRACK() and _PyObject_GC_UNTRACK() macros to pycore_object.h * Remove _PyGC_generation0: replaced with _PyRuntime.gc.generation0 * Python.h now automatically includes pycore_object.h
vstinner
commented
Nov 13, 2018
MemberAuthor
PR #10507 has been merged: I rewrote and rebased this change on top of master. |
vstinner
commented
Nov 13, 2018
MemberAuthor
I don't understand why compilation fails on AppVeyor: |
vstinner
commented
Nov 21, 2018
MemberAuthor
I merged PR #10640 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pycore_object.h
in _queuemodule.c. The file is compiled without Py_BUILD_CORE.
https://bugs.python.org/issue35081