Skip to content

gh-100227: Make the Global PyModuleDef Cache Safe for Isolated Interpreters - #102938

Closed
ericsnowcurrently wants to merge 23 commits into
python:mainfrom
ericsnowcurrently:extensions-dict-owned-by-main-interpreter
Closed

gh-100227: Make the Global PyModuleDef Cache Safe for Isolated Interpreters#102938
ericsnowcurrently wants to merge 23 commits into
python:mainfrom
ericsnowcurrently:extensions-dict-owned-by-main-interpreter

Conversation

@ericsnowcurrently

@ericsnowcurrentlyericsnowcurrently commented Mar 22, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

This is a similar change to gh-102925, but applied to the global cache of PyModuleDefs instead of the interned strings. Note that the cache is only used for legacy extension modules and not for multi-phase init modules.

(Until gh-102925 is merged, this is based on top of it.)

@ericsnowcurrently
Factor out add_threadstate().
546b934
@ericsnowcurrently
Add _PyThreadState_InitDetached().
0bcd136
@ericsnowcurrently
Add _PyThreadState_ClearDetached().
35d5310
@ericsnowcurrently
Add _PyRuntime.cached_objects.main_tstate.
cba9e34
@ericsnowcurrently
Add _Py_AcquireGlobalObjectsState() and _Py_ReleaseGlobalObjectsState().
3b1bb8b
@ericsnowcurrently
Add _Py_AddToGlobalDict().
eb42aa1
@ericsnowcurrently
Drop _Py_AcquireGlobalObjectsState() and _Py_ReleaseGlobalObjectsStat…
4e9da2d
…e().
@ericsnowcurrently
Add acquire_global_objects_lock() and release_global_objects_lock().
6216207
@ericsnowcurrently
Add some TODO comments.
3c007c0
@ericsnowcurrently
Factor out store_interned().
7d95514
@ericsnowcurrently
Store a thread state to use just for interned strings.
5c20b84
@ericsnowcurrently
Always use the main interpreter when possibly resizing the interned d…
a3ae02a
…ict.
@ericsnowcurrently
Use _PyRuntime.cached_objects.main_tstate instead.
d5fbc37
@ericsnowcurrently
Add _PyThreadState_IsBound() and _PyThreadState_Unbind().
459325f
@ericsnowcurrently
Make sure the one-off tstate is bound before using it.
4f25244
@ericsnowcurrently
Use _Py_AcquireGlobalObjectsState() in store_interned().
e68535a
@ericsnowcurrently
Use _Py_AddToGlobalDict().
22753b3
@ericsnowcurrently
Move the extensions dict to _PyRuntime.cached_objects.
5c7bfd7
@ericsnowcurrently
Add _Py_GetFromGlobalDict().
f1a33ce
@ericsnowcurrently
Add _Py_PopFromGlobalDict().
10e6d69
@ericsnowcurrently
Adjust _Py_AddToGlobalDict().
7dbae68
@ericsnowcurrently
Use _Py_PopFromGlobalDict() in unicode_dealloc().
3e08c1f
@ericsnowcurrently
Use the global dict API in import.c.
1039a60
@bedevere-botbedevere-bot mentioned this pull request Mar 22, 2023
Closed
@ericsnowcurrently

ericsnowcurrently commented Mar 28, 2023

Copy link
Copy Markdown
MemberAuthor

I'm closing this in favor of gh-103084.

@ericsnowcurrentlyericsnowcurrently mentioned this pull request Mar 28, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannonbrettcannonAwaiting requested review from brettcannonbrettcannon is a code owner
@encukouencukouAwaiting requested review from encukou
@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner
@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

Assignees

No one assigned

Labels

awaiting core reviewskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ericsnowcurrently@bedevere-bot