gh-103092: Isolate _collections

[erlend-aasland]

• Issue: Isolate Stdlib Extension Modules #103092

[kumaraditya303]

LGTM, I finished the remaining bits.

[kumaraditya303]

Now it crashes in the dict watcher deallocation, cc @carljm

[erlend-aasland]

Now it crashes in the dict watcher deallocation, cc @carljm

See 45a26f3, which I believe is the correct prescription. Notice that PyDict_Type.tp_init is called explicitly from defdict_init. IIRC, that is not needed, but I may be wrong (I'm unable to check that right now).

[erlend-aasland]

BTW, there are ref. leaks, so we need to hold off a little bit more. Try for example checking ref. leaks on test_defaultdict.

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 0dcfcef 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 0381b45 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

[erlend-aasland]

Good find! No ref.leaks locally over here.

[kumaraditya303]

Final approval!

[erlend-aasland]

Good job!