Skip to content

gh-103171: Document and test behaviour change in 3.11 for runtime-checkable protocols decorated with @final - #103173

Closed
AlexWaygood wants to merge 2 commits into
python:mainfrom
AlexWaygood:document-runtimecheckable-final-change
Closed

gh-103171: Document and test behaviour change in 3.11 for runtime-checkable protocols decorated with @final#103173
AlexWaygood wants to merge 2 commits into
python:mainfrom
AlexWaygood:document-runtimecheckable-final-change

Conversation

@AlexWaygood

@AlexWaygoodAlexWaygood commented Apr 1, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@bedevere-botbedevere-bot mentioned this pull request Apr 1, 2023
Closed
@bedevere-botbedevere-bot added docs Documentation in the Doc dir skip news labels Apr 1, 2023
@AlexWaygood
AlexWaygood removed the request for review from gvanrossumApril 1, 2023 15:36
@AlexWaygood
AlexWaygood marked this pull request as draft April 1, 2023 15:55
@AlexWaygoodAlexWaygood changed the title gh-103171: Document behaviour change in 3.11 for runtime-checkable protocols decorated with @finalgh-103171: Document and test behaviour change in 3.11 for runtime-checkable protocols decorated with @finalApr 1, 2023
@AlexWaygood
AlexWaygood marked this pull request as ready for review April 1, 2023 16:00
@AlexWaygoodAlexWaygood added tests Tests in the Lib/test dir DO-NOT-MERGE labels Apr 1, 2023
@AlexWaygood

AlexWaygood commented Apr 1, 2023

Copy link
Copy Markdown
MemberAuthor

Marking as DO-NOT-MERGE until discussion on the issue has finished: #103171 (comment)

JelleZijlstra
JelleZijlstra requested changes Jun 7, 2023
View reviewed changes

@JelleZijlstraJelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to instead change the behavior, see the issue.

(Also I want this to go out of my review requested list.)

@bedevere-bot

bedevere-bot commented Jun 7, 2023

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@AlexWaygood

AlexWaygood commented Jun 7, 2023

Copy link
Copy Markdown
MemberAuthor

I'd like to instead change the behavior, see the issue.

In that case I'll close this PR for now, since the better approach will probably be to fix the behavior in a PR to the 3.11 branch, and then "forward-port" the tests from that PR to main/3.12. And I won't be able to change the target branch on this PR without pinging all core developers past, present and future

@AlexWaygood
AlexWaygood deleted the document-runtimecheckable-final-change branch June 7, 2023 12:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra requested changes
@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-Spinner

Assignees

No one assigned

Labels

awaiting changesDO-NOT-MERGEdocsDocumentation in the Doc dirneeds backport to 3.11only security fixesskip newstestsTests in the Lib/test dirtopic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexWaygood@bedevere-bot@JelleZijlstra