Uh oh!
There was an error while loading. Please reload this page.
GH-75586: Fix case where PATHEXT isn't applied to items in PATH (Windows) - #103179
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
csm10495
commented
Apr 2, 2023
@eryksun I think i fixed everything. Check again. Thanks! |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Eryk Sun <eryksun@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Eryk Sun <eryksun@gmail.com>
Co-authored-by: Eryk Sun <eryksun@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
csm10495
commented
Apr 4, 2023
@zooba updated and added a corresponding test. |
zooba
commented
Apr 4, 2023
Looks good, and the tests all patch the call to that API so we shouldn't be impacted if the test machine has it configured differently. Once CI passes, and unless someone else speaks up, I'll merge. Thanks for all your work on this! |
csm10495
commented
Apr 4, 2023
Got a doctest failure... The error is odd.. maybe its transient? I'll push an empty commit to see if it helps. |
Uh oh!
There was an error while loading. Please reload this page.
csm10495
commented
Apr 4, 2023
@eryksun added. Thanks. |
vstinner
commented
Nov 19, 2024
This change introduced a regression: #127001. |
GH-75586 - Fix case where PATHEXT isn't applied to items in PATH.
The logic change here makes it so that if the command passed into
shutil.whichon windows, it will be verified against how it is passed in and against the various items in PATHEXT.For example:
will now return
Instead of
None.If this looks good, I'd be happy to create a changelog entry, etc. Just feeling the water with this first commit.