Skip to content

gh-103092: Isolate winsound - #103249

Merged
erlend-aasland merged 5 commits into
python:mainfrom
aisk:isolate-winsound
Apr 10, 2023
Merged

gh-103092: Isolate winsound#103249
erlend-aasland merged 5 commits into
python:mainfrom
aisk:isolate-winsound

Conversation

@aisk

@aiskaisk commented Apr 4, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@aisk
aisk requested a review from a team as a code ownerApril 4, 2023 16:08
@bedevere-botbedevere-bot mentioned this pull request Apr 4, 2023
Closed
25 tasks
arhadthedev
arhadthedev reviewed Apr 5, 2023
View reviewed changes
Comment threadPC/winsound.c Outdated
@aisk@arhadthedev
Update PC/winsound.c
0a7e6f8
Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
@erlend-aasland
erlend-aasland self-requested a review April 8, 2023 19:48
erlend-aasland
erlend-aasland reviewed Apr 8, 2023
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2023-04-04-21-27-51.gh-issue-103092.7s7Bzf.rst Outdated
Comment threadPC/winsound.c Outdated
@erlend-aaslanderlend-aasland changed the title gh-103092: isolate winsoundgh-103092: Isolate winsoundApr 8, 2023
@erlend-aasland

This comment was marked as outdated.

Sign in to view
aiskand others added 2 commits April 9, 2023 13:03
@aisk@erlend-aasland
Update Misc/NEWS.d/next/Library/2023-04-04-21-27-51.gh-issue-103092.7…
4608cd7
…s7Bzf.rst
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@aisk@erlend-aasland
Update PC/winsound.c
d16e2cd
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@erlend-aasland

This comment was marked as resolved.

Sign in to view
@erlend-aasland

erlend-aasland commented Apr 9, 2023

Copy link
Copy Markdown
Contributor

@zooba, do you want to take a look?

@erlend-aasland
erlend-aasland merged commit f80014a into python:mainApr 10, 2023
@aisk
aisk deleted the isolate-winsound branch April 11, 2023 04:52
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@aisk@warsaw
pythongh-103092: Isolate winsound (python#103249)
e1fef37
aisk added a commit to aisk/cpython that referenced this pull request Apr 18, 2023
@aisk
pythongh-103092: Isolate winsound (python#103249)
ef5db87
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arhadthedevarhadthedevarhadthedev left review comments
@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aisk@erlend-aasland@arhadthedev@bedevere-bot