Uh oh!
There was an error while loading. Please reload this page.
gh-74690: Add more tests for runtime-checkable protocols - #103347
Merged
Conversation
AlexWaygood
requested review from
Fidget-Spinner, JelleZijlstra and gvanrossum
as code ownersApril 7, 2023 13:42
carljm
approved these changes
Apr 7, 2023
miss-islington
commented
Apr 7, 2023
Contributor
Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 7, 2023
…nGH-103347) (cherry picked from commit 800382a) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
bedevere-bot
commented
Apr 7, 2023
GH-103350 is a backport of this pull request to the 3.11 branch. |
miss-islington added a commit
that referenced
this pull request
Apr 7, 2023
warsaw pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds more tests for runtime-checkable protocols, ensuring various edge cases are covered. Some of the invariants I'm adding tests for would have been broken by some more hare-brained optimisations that we considered, but rejected, in #74690 and #103310.