Skip to content

GH-103379: Fix up old tests for pathlib.PurePath._parse_path - #103380

Merged
barneygale merged 4 commits into
python:mainfrom
barneygale:remove-flavour-tests
Apr 9, 2023
Merged

GH-103379: Fix up old tests for pathlib.PurePath._parse_path#103380
barneygale merged 4 commits into
python:mainfrom
barneygale:remove-flavour-tests

Conversation

@barneygale

@barneygalebarneygale commented Apr 8, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

These tests now make assertions about the public PurePath.drive, root and parts attributes, rather than an internal method. They're moved out of the _BaseFlavourTest, PosixFlavourTest and NTFlavourTest classes, which are removed.

@barneygale
pythonGH-103379: Fix up old tests forpathlib.PurePath._parse_parts()
2fc2192
These tests now make assertions about the public `PurePath.drive`, `root`
and `parts` attributes, rather than an internal method. They're moved out
of the `_BaseFlavourTest`, `PosixFlavourTest` and `NTFlavourTest` classes,
which are removed.
@barneygalebarneygale added tests Tests in the Lib/test dir skip news topic-pathlib labels Apr 8, 2023
@bedevere-botbedevere-bot mentioned this pull request Apr 8, 2023
Closed
@barneygalebarneygale mentioned this pull request Apr 8, 2023
Merged
terryjreedy
terryjreedy reviewed Apr 8, 2023
View reviewed changes

@terryjreedyterryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen discussions of whether or not to write tests for private functions and am somewhat on the fence. Since you propose to merely change the existing tests, rather than delete them, and the change makes it clearer (to me) what is really being tested, I approve.

Comment threadLib/test/test_pathlib.py
terryjreedy
terryjreedy reviewed Apr 8, 2023
View reviewed changes
Comment threadLib/test/test_pathlib.py Outdated
@terryjreedyterryjreedy changed the title GH-103379: Fix up old tests for pathlib.PurePath._parse_parts()GH-103379: Fix up old tests for pathlib.PurePath._parse_pathApr 8, 2023
terryjreedy
terryjreedy reviewed Apr 8, 2023
View reviewed changes

@terryjreedyterryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The calls with first and last args being flat tuples looks fine. This looks better to me than before.

Comment threadLib/test/test_pathlib.py
barneygaleand others added 2 commits April 9, 2023 03:22
@barneygale@terryjreedy
Update Lib/test/test_pathlib.py
572d152
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@barneygale
Fix tests; use assignment operator.
61eca57
AlexWaygood
AlexWaygood approved these changes Apr 9, 2023
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me -- thanks @barneygale!

@barneygale
barneygale merged commit 0a675f4 into python:mainApr 9, 2023
@barneygale

barneygale commented Apr 9, 2023

Copy link
Copy Markdown
ContributorAuthor

Thank you both!

warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@barneygale@terryjreedy@warsaw
pythonGH-103379: Fix up old tests forpathlib.PurePath._parse_path(p…
d05e4bc
…ythonGH-103380)
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
aisk pushed a commit to aisk/cpython that referenced this pull request Apr 18, 2023
@barneygale@terryjreedy@aisk
pythonGH-103379: Fix up old tests forpathlib.PurePath._parse_path(p…
275f466
…ythonGH-103380)
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedyterryjreedyterryjreedy left review comments
@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dirtopic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@barneygale@terryjreedy@AlexWaygood@bedevere-bot