Skip to content

gh-67230: document new csv quoting modes in whatsnew (gh-103491) - #103491

Merged
merwok merged 3 commits into
python:mainfrom
smontanaro:patch-4
Apr 13, 2023
Merged

gh-67230: document new csv quoting modes in whatsnew (gh-103491)#103491
merwok merged 3 commits into
python:mainfrom
smontanaro:patch-4

Conversation

@smontanaro

@smontanarosmontanaro commented Apr 12, 2023

Copy link
Copy Markdown
Contributor

Add blurb about recent change to csv.

Add blurb about changes to :mod:`csv`.
@bedevere-botbedevere-bot added docs Documentation in the Doc dir skip news awaiting review labels Apr 12, 2023
@merwokmerwok changed the title Update 3.12.rstbpo-67230: document new csv quoting modes in whatsnewApr 12, 2023
@merwokmerwok changed the title bpo-67230: document new csv quoting modes in whatsnewgh-67230: document new csv quoting modes in whatsnewApr 12, 2023
Comment threadDoc/whatsnew/3.12.rst Outdated
Comment threadDoc/whatsnew/3.12.rst Outdated
@bedevere-bot

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Comment threadDoc/whatsnew/3.12.rst Outdated
@merwokmerwok self-assigned this Apr 12, 2023
@smontanaro

Copy link
Copy Markdown
ContributorAuthor

This interface is horrible. I see a change was rewuested by @merwok but can't see what it is. So...

I have made the requested changes; please review again.

@bedevere-bot

Copy link
Copy Markdown

Thanks for making the requested changes!

@merwok: please review the changes made to this pull request.

@merwok

Copy link
Copy Markdown
Member

I see a change was requested by merwok but can't see what it is. So...

Ah! «requested changes» is a review status (others are «approved» and «commented»)
Comments can be standalone or part of a review; I used the latter mode, made a few comments (some being change suggestions) and published my review with the «changes requested» status. Then I applied some of my suggested changes directly. So you saw «changes requested», some hidden comments («resolved» by the application of the suggestion), and one comment about the wording.

@merwokmerwok changed the title gh-67230: document new csv quoting modes in whatsnewgh-67230: document new csv quoting modes in whatsnew (gh-103491)Apr 13, 2023
@merwok
merwok merged commit fb38c1b into python:mainApr 13, 2023
@samwyse

Copy link
Copy Markdown
Contributor

@smontanaro looks good! I tried to do this myself last night, but I was at my kid's soccer practice and discovered that the official iPhone GitHub app does not have all the functionality of the web GUI. 😢

@smontanaro

smontanaro commented Apr 13, 2023 via email

Copy link
Copy Markdown
ContributorAuthor

aisk pushed a commit to aisk/cpython that referenced this pull request Apr 18, 2023
@chaeynz

Copy link
Copy Markdown

@smontanaro were you responsible for the csv.QUOTE_NULL?

You're an absolute legend!
I am working a project where I need exactly this, thank you so much! :)

@smontanaro

Copy link
Copy Markdown
ContributorAuthor

Not exactly. Someone else suggested it years ago. I tend to catch most proposed changes to the csv module...

KNGSJ

This comment was marked as off-topic.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@smontanaro@bedevere-bot@merwok@samwyse@chaeynz@KNGSJ