Skip to content

gh-103673: Add missing ForkingUnixStreamServer and ForkingUnixDatagramServer socketservers - #103674

Merged
gpshead merged 11 commits into
python:mainfrom
jb2170:gh-103673
Apr 24, 2023
Merged

gh-103673: Add missing ForkingUnixStreamServer and ForkingUnixDatagramServer socketservers#103674
gpshead merged 11 commits into
python:mainfrom
jb2170:gh-103673

Conversation

@jb2170

@jb2170jb2170 commented Apr 22, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-botbedevere-bot mentioned this pull request Apr 22, 2023
Closed
@sobolevnsobolevn changed the title gh-103673gh-103673: Add missing ForkingUnixStreamServer and ForkingUnixDatagramServer socketserversApr 22, 2023
sobolevn
sobolevn reviewed Apr 22, 2023
View reviewed changes

@sobolevnsobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the feature suggestion and the implementation.

Please, to increase the chances of this feature been accepted, add tests and docs: when to use these new types of servers, how, etc.

Comment threadLib/socketserver.py Outdated
@gpsheadgpshead self-assigned this Apr 23, 2023
gpsheadand others added 6 commits April 23, 2023 12:44
@gpshead@sobolevn
style nit: add a missing space.
d634059
admittedly other existing lines don't always do this. this module is very old code.
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@gpshead
ReSTify the NEWS entry.
a9a91ed
@gpshead
remove an unnecessary word in NEWS
e32b567
@arhadthedev
Add authorship
58073d4
@jb2170
Update Lib/test/test_socketserver.py to use ForkingUnix{Stream,Datagr…
5f61e05
…am}Server from socketserver
@jb2170
Merge branch 'main' intopythongh-103673
afb4520
@jb2170

jb2170 commented Apr 24, 2023

Copy link
Copy Markdown
ContributorAuthor

add tests

I have now updated Lib/test/test_socketserver.py to include the appropriate tests. Turns out it was defining its own ForkingUnix{Stream,Datagram}Server within the test file exactly as we are adding to socketserver, who would've guessed hahaha.

and docs

The current docs already describe in detail the ThreadingMixIn and ForkingMixIn, when to use them etc. The only thing that really needed adding was the mentions of the new servers at the 'These classes are pre-defined using the mix-in classes' section. The existing documentation only mentions the {Forking,Threading}{TCP,UDP}Server classes once in this section, and the new docs in this PR are consistent with this; the documentation seems enough.

Thanks for the intermediary commits. The PR is now up-to-date again with main and is conflict free.

@gpshead
gpshead enabled auto-merge (squash) April 24, 2023 22:06
@gpshead
gpshead merged commit d94b3a6 into python:mainApr 24, 2023
@jb2170
jb2170 deleted the gh-103673 branch April 24, 2023 22:48
carljm added a commit to carljm/cpython that referenced this pull request Apr 24, 2023
@carljm
Merge branch 'main' into superopt_spec
3236f45
* main:
pythongh-103801: Tools/wasm linting and formatting (python#103796)
pythongh-103673: Add missing ForkingUnixStreamServer and ForkingUnixDatagramServer socketservers (python#103674)
pythongh-95795: Move types.next_version_tag to PyInterpreterState (pythongh-102343)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevnsobolevnsobolevn left review comments
@gpsheadgpsheadgpshead approved these changes

Assignees

@gpsheadgpshead

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jb2170@gpshead@sobolevn@bedevere-bot@arhadthedev