Skip to content

gh-103685: Fix tkinter.Menu.index() for Tk 8.7 - #103686

Merged
terryjreedy merged 7 commits into
python:mainfrom
chrstphrchvz:patch-103685
Apr 24, 2023
Merged

gh-103685: Fix tkinter.Menu.index() for Tk 8.7#103686
terryjreedy merged 7 commits into
python:mainfrom
chrstphrchvz:patch-103685

Conversation

@chrstphrchvz

@chrstphrchvzchrstphrchvz commented Apr 22, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-botbedevere-bot mentioned this pull request Apr 22, 2023
Closed
@arhadthedevarhadthedev added stdlib Standard Library Python modules in the Lib/ directory topic-tkinter labels Apr 22, 2023
terryjreedy
terryjreedy reviewed Apr 22, 2023
View reviewed changes
Comment threadLib/tkinter/__init__.py Outdated
@terryjreedy

terryjreedy commented Apr 22, 2023

Copy link
Copy Markdown
Member

Christopher: Add blurb with something like "Make tkinter.Menu.index('none') continue to work in tk 8.7."

@serhiy-storchaka Do we consider tkinter failures due to tcl/tk changes to be bugs, such that fixes should be backported? I am thinking so and plan to merge and backport unless you say something.

@chrstphrchvz@terryjreedy
Update Lib/tkinter/__init__.py
a293a6b
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@serhiy-storchaka

serhiy-storchaka commented Apr 23, 2023

Copy link
Copy Markdown
Member

I agree that it should be backported.

@chrstphrchvz Do existing tests cover this case? Or a new test is needed?

@serhiy-storchakaserhiy-storchaka added the needs backport to 3.11 only security fixes label Apr 23, 2023
@chrstphrchvz

chrstphrchvz commented Apr 23, 2023

Copy link
Copy Markdown
ContributorAuthor

@chrstphrchvz Do existing tests cover this case? Or a new test is needed?

I did not notice the error in any existing test.test_tkinter tests, so I have added a test for this. The error does prevent IDLE from launching (at least on Aqua), though.

This PR is probably one of the smaller and easier to understand changes needed for Tk 8.7, but in practice it is likely not useful without first addressing e.g. #103194, so presumably there would be more to backport.

terryjreedy
terryjreedy reviewed Apr 23, 2023
View reviewed changes
Comment threadLib/test/test_tkinter/test_widgets.py
@terryjreedy
terryjreedy marked this pull request as ready for review April 23, 2023 20:49
@terryjreedy

terryjreedy commented Apr 23, 2023

Copy link
Copy Markdown
Member

Properly testing tkinter, etc, with 8.7 requires a buildbot that installs the latest 8.7, which we don't have yet. I have no idea whether the linux x simulator can simulate 8.7 yet.

Again, please add a blurb. Perhaps "Make tkinter.Menu.index('none') work in tcl/tk versions being developed." is slightly better that what i wrote above.

terryjreedy
terryjreedy reviewed Apr 23, 2023
View reviewed changes
Comment threadLib/test/test_tkinter/test_widgets.py Outdated
@terryjreedy
terryjreedy merged commit f0ed293 into python:mainApr 24, 2023
@miss-islington

miss-islington commented Apr 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @chrstphrchvz for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 24, 2023
@chrstphrchvz@terryjreedy
@blurb-it@miss-islington
pythongh-103685: Fix tkinter.Menu.index() for Tk 8.7 (pythonGH-103686)
fdfa148
---------
(cherry picked from commit f0ed293)
Co-authored-by: Christopher Chavez <chrischavez@gmx.us>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Apr 24, 2023

Copy link
Copy Markdown

GH-103734 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Apr 24, 2023
@chrstphrchvz
chrstphrchvz deleted the patch-103685 branch April 24, 2023 01:34
terryjreedy added a commit that referenced this pull request Apr 24, 2023
@miss-islington@chrstphrchvz
@terryjreedy@blurb-it
[3.11]gh-103685: Fix tkinter.Menu.index() for Tk 8.7 (GH-103686) (#1…
dc08c7a
…03734)
gh-103685: Fix tkinter.Menu.index() for Tk 8.7 (GH-103686)
---------
(cherry picked from commit f0ed293)
Co-authored-by: Christopher Chavez <chrischavez@gmx.us>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedyterryjreedyterryjreedy approved these changes

Assignees

No one assigned

Labels

stdlibStandard Library Python modules in the Lib/ directorytopic-tkinter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@chrstphrchvz@terryjreedy@serhiy-storchaka@miss-islington@bedevere-bot@arhadthedev