Skip to content

gh-103726: Set up gcc-10 for ASAN - #103728

Merged
corona10 merged 2 commits into
python:mainfrom
corona10:gh-103726
Apr 25, 2023
Merged

gh-103726: Set up gcc-10 for ASAN#103728
corona10 merged 2 commits into
python:mainfrom
corona10:gh-103726

Conversation

@corona10

@corona10corona10 commented Apr 23, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@corona10
corona10 requested a review from gpsheadApril 23, 2023 22:36
@bedevere-botbedevere-bot mentioned this pull request Apr 23, 2023
Closed
@corona10

corona10 commented Apr 23, 2023

Copy link
Copy Markdown
MemberAuthor

@gpshead

For ASAN

./python -m test.pythoninfo
Python debug information
========================
CC.version: gcc (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
_decimal.__libmpdec_version__: 2.5.1

@corona10
corona10 marked this pull request as ready for review April 23, 2023 22:42
@corona10

corona10 commented Apr 23, 2023

Copy link
Copy Markdown
MemberAuthor

We can update ./.github/workflows/posix-deps-apt.sh to use GCC-10, but I prefer to use the default gcc version for the general CI.

@corona10
corona10 enabled auto-merge (squash) April 25, 2023 11:45
@corona10
corona10 disabled auto-merge April 25, 2023 11:46
@corona10
corona10 enabled auto-merge (squash) April 25, 2023 11:46
@corona10
corona10 merged commit 8330580 into python:mainApr 25, 2023
@corona10
corona10 deleted the gh-103726 branch April 25, 2023 13:12
@gpsheadgpshead added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels May 23, 2023
@miss-islington

miss-islington commented May 23, 2023

Copy link
Copy Markdown
Contributor

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington

miss-islington commented May 23, 2023

Copy link
Copy Markdown
Contributor

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington

miss-islington commented May 23, 2023

Copy link
Copy Markdown
Contributor

Sorry, @corona10, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 83305808000e03cbad31ac3e9ef65454fb409282 3.10

@bedevere-bot

bedevere-bot commented May 23, 2023

Copy link
Copy Markdown

GH-104794 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label May 23, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 23, 2023
@corona10@miss-islington
pythongh-103726: Set up gcc-10 for ASAN (pythongh-103728)
8944408
<!--
Thanks for your contribution!
Please read this comment in its entirety. It's quite important.
GH- Pull Request title
It should be in the following format:
```
gh-NNNNN: Summary of the changes made
```
Where: gh-NNNNN refers to the GitHub issue number.
Most PRs will require an issue number. Trivial changes, like fixing a
typo, do not need an issue.
GH- Backport Pull Request title
If this is a backport PR (PR made against branches other than `main`),
please ensure that the PR title is in the following format:
```
[X.Y] <title from the original PR> (GH-NNNN)
```
Where: [X.Y] is the branch name, e.g. [3.6].
GH-NNNN refers to the PR number from `main`.
-->
<!-- gh-issue-number: pythongh-103726 -->
* Issue: pythongh-103726
<!-- /gh-issue-number -->
(cherry picked from commit 8330580)
Co-authored-by: Dong-hee Na <donghee.na@python.org>
@gpsheadgpshead removed the needs backport to 3.10 only security fixes label May 23, 2023
gpshead pushed a commit that referenced this pull request May 23, 2023
@miss-islington@corona10
[3.11]gh-103726: Set up gcc-10 for ASAN (gh-103728) (#104794)
ac12a6b
Set up gcc-10 for ASAN CI as the existing config's default 9.x does not
play well with `vfork()`.
<!--
Thanks for your contribution!
Please read this comment in its entirety. It's quite important.
GH- Pull Request title
It should be in the following format:
```
gh-NNNNN: Summary of the changes made
```
Where: gh-NNNNN refers to the GitHub issue number.
Most PRs will require an issue number. Trivial changes, like fixing a
typo, do not need an issue.
GH- Backport Pull Request title
If this is a backport PR (PR made against branches other than `main`),
please ensure that the PR title is in the following format:
```
[X.Y] <title from the original PR> (GH-NNNN)
```
Where: [X.Y] is the branch name, e.g. [3.6].
GH-NNNN refers to the PR number from `main`.
-->
<!-- gh-issue-number: gh-103726 -->
* Issue: gh-103726
<!-- /gh-issue-number -->
(cherry picked from commit 8330580)
Co-authored-by: Dong-hee Na <donghee.na@python.org>
This was referenced Jul 1, 2026
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpsheadgpsheadgpshead approved these changes
@hugovkhugovkhugovk approved these changes
@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

Assignees

@corona10corona10

Labels

awaiting mergeskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@corona10@miss-islington@bedevere-bot@gpshead@hugovk