gh-103636: issue warning for deprecated calendar constants by Agent-Hellboy · Pull Request #103833 · python/cpython

Agent-Hellboy · 2023-04-25T14:56:14Z

Issue: Convert calendar constants to enums and add months #103636

hugovk

Please could you add a NEWS file and document the deprecation at https://docs.python.org/3.12/whatsnew/3.12.html#deprecated?

bedevere-bot · 2023-04-26T17:22:38Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Agent-Hellboy · 2023-04-26T18:41:59Z

I have made the requested changes; please review again

bedevere-bot · 2023-04-26T18:42:03Z

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

Agent-Hellboy · 2023-04-27T03:26:58Z

sorry for the silly mistakes, I have made the requested changes; please review again

bedevere-bot · 2023-04-27T03:27:01Z

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

hugovk

Tip: You can directly apply all the suggestions you want in one go with Files changed -> Add to batch -> Commit

bedevere-bot · 2023-04-27T12:40:51Z

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

Co-authored-by: Éric <merwok@netwok.org>

hugovk

Thanks, almost there!

bedevere-bot · 2023-04-28T03:36:09Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

hugovk

Thank you!

* main: (26 commits) pythongh-104028: Reduce object creation while calling callback function from gc (pythongh-104030) pythongh-104036: Fix direct invocation of test_typing (python#104037) pythongh-102213: Optimize the performance of `__getattr__` (pythonGH-103761) pythongh-103895: Improve how invalid `Exception.__notes__` are displayed (python#103897) Adjust expression from `==` to `!=` in alignment with the meaning of the paragraph. (pythonGH-104021) pythongh-88496: Fix IDLE test hang on macOS (python#104025) Improve int test coverage (python#104024) pythongh-88773: Added teleport method to Turtle library (python#103974) pythongh-104015: Fix direct invocation of `test_dataclasses` (python#104017) pythongh-104012: Ensure test_calendar.CalendarTestCase.test_deprecation_warning consistently passes (python#104014) pythongh-103977: compile re expressions in platform.py only if required (python#103981) pythongh-98003: Inline call frames for CALL_FUNCTION_EX (pythonGH-98004) Replace Netlify with Read the Docs build previews (python#103843) Update name in acknowledgements and add mailmap (python#103696) pythongh-82054: allow test runner to split test_asyncio to execute in parallel by sharding. (python#103927) Remove non-existing tools from Sundry skiplist (python#103991) pythongh-103793: Defer formatting task name (python#103767) pythongh-87092: change assembler to use instruction sequence instead of CFG (python#103933) pythongh-103636: issue warning for deprecated calendar constants (python#103833) Various small fixes to dis docs (python#103923) ...

Agent-Hellboy added 2 commits April 25, 2023 20:23

pythongh-103636: raise warning for January and February attribute
175dadf

add test
97436c8

bedevere-bot mentioned this pull request Apr 26, 2023
Convert calendar constants to enums and add months #103636
Closed

arhadthedev added the stdlib Standard Library Python modules in the Lib/ directory label Apr 26, 2023

hugovk requested changes Apr 26, 2023
View reviewed changes

Comment threadLib/calendar.py Outdated
Comment threadLib/calendar.py Outdated
Comment threadLib/calendar.py Outdated
Comment threadLib/calendar.py Outdated
Comment threadLib/calendar.py Outdated
Comment threadLib/test/test_calendar.py Outdated

bedevere-bot added the awaiting changes label Apr 26, 2023

merwok reviewed Apr 26, 2023
View reviewed changes

Comment threadLib/test/test_calendar.py Outdated

blurb-itBotand others added 3 commits April 26, 2023 18:12

📜🤖 Added by blurb_it.
e6f2a2f

update docs for depration warning and new additions
5a4d0a7

dedent line in calendar test
ddcdc43

bedevere-bot added awaiting change review and removed awaiting changes labels Apr 26, 2023

bedevere-bot requested a review from hugovk April 26, 2023 18:42

Agent-Hellboy added 5 commits April 27, 2023 00:24

fix doc
794dddc

fix doc
717cea8

fix doc
b2c13e8

fix doc
029844f

fix doc
0c52a19

merwok reviewed Apr 26, 2023
View reviewed changes

Comment threadDoc/whatsnew/3.12.rst Outdated

merwok reviewed Apr 26, 2023
View reviewed changes

Comment threadLib/calendar.py Outdated
Comment threadLib/calendar.py Outdated
Comment threadLib/calendar.py
Comment threadLib/test/test_calendar.py Outdated
Comment threadMisc/NEWS.d/next/Library/2023-04-26-18-12-13.gh-issue-103636.-KvCgO.rst Outdated

merwok added 2 commits April 26, 2023 17:35

fix spacing
ac783cf

Merge branch 'main' into raise-warning-in-calendar-mod
a18a064

merwok reviewed Apr 26, 2023
View reviewed changes

Comment threadDoc/library/calendar.rst Outdated

fix grametical mistake
e002e10

hugovk requested changes Apr 27, 2023
View reviewed changes

Comment threadDoc/whatsnew/3.12.rst Outdated
Comment threadMisc/NEWS.d/next/Library/2023-04-26-18-12-13.gh-issue-103636.-KvCgO.rst Outdated
Comment threadDoc/whatsnew/3.12.rst Outdated
Comment threadDoc/whatsnew/3.12.rst Outdated

bedevere-bot added awaiting change review and removed awaiting changes labels Apr 27, 2023

bedevere-bot requested a review from hugovk April 27, 2023 12:40

merwok reviewed Apr 27, 2023
View reviewed changes

Comment threadDoc/whatsnew/3.12.rst Outdated

merwok reviewed Apr 27, 2023
View reviewed changes

Comment threadDoc/whatsnew/3.12.rst Outdated

Agent-Hellboyand others added 3 commits April 27, 2023 20:14

Update Doc/whatsnew/3.12.rst
49079d1
Co-authored-by: Éric <merwok@netwok.org>

Update Doc/whatsnew/3.12.rst
db53e78
Co-authored-by: Éric <merwok@netwok.org>

fix doc
9c289c5

merwok changed the title ~~gh-103636: raise warning for January and February attribute~~gh-103636: issue warning for deprecated calendar constantsApr 27, 2023

Merge branch 'main' into raise-warning-in-calendar-mod
4b497b2

merwok approved these changes Apr 27, 2023
View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Apr 27, 2023

merwok assigned hugovk Apr 27, 2023

merwok added 3.12 only security fixes awaiting core review and removed awaiting merge labels Apr 27, 2023

hugovk requested changes Apr 28, 2023
View reviewed changes

Comment threadDoc/library/calendar.rst
Comment threadDoc/library/calendar.rst

bedevere-bot added awaiting changes and removed awaiting core review labels Apr 28, 2023

Agent-Hellboyand others added 2 commits April 28, 2023 09:23

Update Doc/library/calendar.rst
7ec1945
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

Update Doc/library/calendar.rst
7628f11
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

hugovk approved these changes Apr 28, 2023
View reviewed changes

bedevere-bot added awaiting merge and removed awaiting changes labels Apr 28, 2023

hugovk merged commit 84e7d0f into python:mainApr 29, 2023

bedevere-bot removed the awaiting merge label Apr 29, 2023

Uh oh!

Uh oh!

Conversation

Agent-Hellboy commented Apr 25, 2023• edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hugovk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Apr 26, 2023

Uh oh!

Uh oh!

Agent-Hellboy commented Apr 26, 2023

Uh oh!

bedevere-bot commented Apr 26, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Agent-Hellboy commented Apr 27, 2023

Uh oh!

bedevere-bot commented Apr 27, 2023

Uh oh!

hugovk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Apr 27, 2023

Uh oh!

Uh oh!

Uh oh!

hugovk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Apr 28, 2023

Uh oh!

hugovk left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Agent-Hellboy commented Apr 25, 2023•
edited by bedevere-bot
Loading