Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 35.2k
Replace Netlify with Read the Docs build previews#103843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
a4f030b855290c8008308c4213832d049978d7a571File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| name: Read the Docs PR preview | ||
| # Automatically edits a pull request's descriptions with a link | ||
| # to the documentation's preview on Read the Docs. | ||
| on: | ||
| pull_request_target: | ||
| types: | ||
| - opened | ||
| paths: | ||
| - 'Doc/**' | ||
| - '.github/workflows/doc.yml' | ||
| permissions: | ||
hugovk marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| pull-requests: write | ||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} | ||
| cancel-in-progress: true | ||
| jobs: | ||
| documentation-links: | ||
CAM-Gerlach marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: readthedocs/actions/preview@v1 | ||
| with: | ||
| project-slug: "cpython-previews" | ||
| single-version: "true" | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # Read the Docs configuration file | ||
| # See https://docs.readthedocs.io/en/stable/config-file/v2.html for details | ||
| # Project page: https://readthedocs.org/projects/cpython-previews/ | ||
| version: 2 | ||
| sphinx: | ||
| configuration: Doc/conf.py | ||
| build: | ||
| os: ubuntu-22.04 | ||
| tools: | ||
| python: "3" | ||
| commands: | ||
| - make -C Doc venv html | ||
| - mkdir _readthedocs | ||
| - mv Doc/build/html _readthedocs/html |
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somewhat unrelated to this specific PR, but I think it would be useful to add a comment (or a docstring-like description if there is a field for it) to document what the workflow is for. If it's not possible to do it here, we could document the workflows either in a README in the dir or somewhere in the devguide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion @ezio-melotti
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added!