Skip to content

gh-98822: Add missing test directories to TESTSUBDIRS - #103942

Merged
erlend-aasland merged 2 commits into
python:mainfrom
erlend-aasland:testsubdirs
Apr 27, 2023
Merged

gh-98822: Add missing test directories to TESTSUBDIRS#103942
erlend-aasland merged 2 commits into
python:mainfrom
erlend-aasland:testsubdirs

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Apr 27, 2023

Copy link
Copy Markdown
Contributor

@erlend-aasland

Copy link
Copy Markdown
ContributorAuthor

Simply the sorted output of find Lib/test -type d.

@erlend-aasland

Copy link
Copy Markdown
ContributorAuthor

BTW, obviously needs a manual backport.

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry @erlend-aasland, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker bf0b8a9f8d647515170cbdf3b6a8c0f44e0f37b3 3.11

@erlend-aasland

Copy link
Copy Markdown
ContributorAuthor

Thanks for the review, Zach.

@erlend-aasland

Copy link
Copy Markdown
ContributorAuthor

Oh, I merged before the macOS CI was finished; sorry 'bout that!

@bedevere-bot

Copy link
Copy Markdown

GH-103946 is a backport of this pull request to the 3.11 branch.

@asottile

Copy link
Copy Markdown
Contributor

this shouldn't have been backported verbatim to 3.11 -- the subdirs added there are incorrect (for example the tkinter ones)

@zware

Copy link
Copy Markdown
Member

Ah, whoops; we did miss some differences. See GH-103970.

@erlend-aasland

Copy link
Copy Markdown
ContributorAuthor

this shouldn't have been backported verbatim to 3.11 -- the subdirs added there are incorrect (for example the tkinter ones)

It wasn't backported verbatim at all.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland@miss-islington@bedevere-bot@asottile@zware