Skip to content

GH-103944: Check error status when raising DeprecationWarning - #103949

Merged
pganssle merged 2 commits into
python:mainfrom
pganssle:utcnow_deprecation_errcheck
Apr 28, 2023
Merged

GH-103944: Check error status when raising DeprecationWarning#103949
pganssle merged 2 commits into
python:mainfrom
pganssle:utcnow_deprecation_errcheck

Conversation

@pganssle

@pgansslepganssle commented Apr 27, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@pganssle
pganssle requested a review from abalkin as a code ownerApril 27, 2023 20:11
@bedevere-botbedevere-bot mentioned this pull request Apr 27, 2023
Closed
erlend-aasland
erlend-aasland reviewed Apr 27, 2023
View reviewed changes

@erlend-aaslanderlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some PEP-7 nits.

Comment threadModules/_datetimemodule.c Outdated
Comment threadModules/_datetimemodule.c Outdated
Comment threadModules/_datetimemodule.c Outdated
Comment threadModules/_datetimemodule.c Outdated
@pganssle
pganssleforce-pushed the utcnow_deprecation_errcheck branch from cecac63 to 0cda214CompareApril 28, 2023 18:50
@pganssle

pganssle commented Apr 28, 2023

Copy link
Copy Markdown
MemberAuthor

@erlend-aasland OK, I've made the relevant changes. Thanks! (My kingdom for an incremental PEP 7 formatter... 😅)

@pganssle
pganssle merged commit 689723a into python:mainApr 28, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes
@abalkinabalkinAwaiting requested review from abalkin
@iritkatrieliritkatrielAwaiting requested review from iritkatriel
@sobolevnsobolevnAwaiting requested review from sobolevn

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pganssle@erlend-aasland@bedevere-bot