gh-84436 Add integration C API tests for immortal objects by corona10 · Pull Request #103962 · python/cpython

corona10 · 2023-04-28T02:13:19Z

Got motivation from #103922 (comment)
This PR is not the answer to the need for emulation mode but for minimum verification.

Issue: Fixing Copy on Writes from reference counting and immortal objects #84436

erlend-aasland

I took a quick look on my phone. I'll take a better look later today.

erlend-aasland

I left some more comments on test_immortal_bool. The same comments applies to the rest of the test functions.

corona10 · 2023-04-30T06:58:06Z

@erlend-aasland @JelleZijlstra @iritkatriel
If there is no major objection, I prefer to merge this PR by next week.
I expect that if the more immortal type is added, more test cases will be added here.

corona10 · 2023-05-02T15:05:18Z

Merge this PR. If there needs some improvement, please let me know!

* main: pythongh-103822: [Calendar] change return value to enum for day and month APIs (pythonGH-103827) pythongh-65022: Fix description of tuple return value in copyreg (python#103892) pythonGH-103525: Improve exception message from `pathlib.PurePath()` (pythonGH-103526) pythongh-84436: Add integration C API tests for immortal objects (pythongh-103962) pythongh-103743: Add PyUnstable_Object_GC_NewWithExtraData (pythonGH-103744) pythongh-102997: Update Windows installer to SQLite 3.41.2. (python#102999) pythonGH-103484: Fix redirected permanently URLs (python#104001) Improve assert_type phrasing (python#104081) pythongh-102997: Update macOS installer to SQLite 3.41.2. (pythonGH-102998) pythonGH-103472: close response in HTTPConnection._tunnel (python#103473) pythongh-88496: IDLE - fix another test on macOS (python#104075) pythongh-94673: Hide Objects in PyTypeObject Behind Accessors (pythongh-104074) pythongh-94673: Properly Initialize and Finalize Static Builtin Types for Each Interpreter (pythongh-104072) pythongh-104016: Skip test for deeply neste f-strings on wasi (python#104071)

* main: (760 commits) pythonGH-104102: Optimize `pathlib.Path.glob()` handling of `../` pattern segments (pythonGH-104103) pythonGH-104104: Optimize `pathlib.Path.glob()` by avoiding repeated calls to `os.path.normcase()` (pythonGH-104105) pythongh-103822: [Calendar] change return value to enum for day and month APIs (pythonGH-103827) pythongh-65022: Fix description of tuple return value in copyreg (python#103892) pythonGH-103525: Improve exception message from `pathlib.PurePath()` (pythonGH-103526) pythongh-84436: Add integration C API tests for immortal objects (pythongh-103962) pythongh-103743: Add PyUnstable_Object_GC_NewWithExtraData (pythonGH-103744) pythongh-102997: Update Windows installer to SQLite 3.41.2. (python#102999) pythonGH-103484: Fix redirected permanently URLs (python#104001) Improve assert_type phrasing (python#104081) pythongh-102997: Update macOS installer to SQLite 3.41.2. (pythonGH-102998) pythonGH-103472: close response in HTTPConnection._tunnel (python#103473) pythongh-88496: IDLE - fix another test on macOS (python#104075) pythongh-94673: Hide Objects in PyTypeObject Behind Accessors (pythongh-104074) pythongh-94673: Properly Initialize and Finalize Static Builtin Types for Each Interpreter (pythongh-104072) pythongh-104016: Skip test for deeply neste f-strings on wasi (python#104071) pythongh-104057: Fix direct invocation of test_super (python#104064) pythongh-87092: Expose assembler to unit tests (python#103988) pythongh-97696: asyncio eager tasks factory (python#102853) pythongh-84436: Immortalize in _PyStructSequence_InitBuiltinWithFlags() (pythongh-104054) ...

corona10 requested review from JelleZijlstra, erlend-aasland and iritkatriel April 28, 2023 02:13

corona10 requested a review from a team as a code owner April 28, 2023 02:13

bedevere-bot mentioned this pull request Apr 28, 2023
Fixing Copy on Writes from reference counting and immortal objects #84436
Closed

bedevere-bot added the awaiting core review label Apr 28, 2023

corona10 commented Apr 28, 2023
View reviewed changes

Comment threadPCbuild/_testcapi.vcxproj Outdated

corona10 added the skip news label Apr 28, 2023

corona10 force-pushed the gh-84436-objects branch from 7adb521 to b8451a5Compare April 28, 2023 02:22

erlend-aasland reviewed Apr 28, 2023
View reviewed changes

Comment threadModules/_testcapi/immortal.c Outdated
Comment threadModules/_testcapi/immortal.c Outdated
Comment threadModules/_testcapi/immortal.c Outdated
Comment threadModules/_testcapi/immortal.c Outdated
Comment threadModules/_testcapi/immortal.c Outdated

corona10 requested a review from erlend-aasland April 28, 2023 05:48

erlend-aasland reviewed Apr 28, 2023
View reviewed changes

Comment threadModules/_testcapi/immortal.c Outdated
Comment threadModules/_testcapi/immortal.c Outdated
Comment threadModules/_testcapi/immortal.c Outdated
Comment threadModules/_testcapi/immortal.c Outdated

corona10 requested a review from erlend-aasland April 28, 2023 11:26

JelleZijlstra changed the title ~~gh-84436 Add intergration C API tests for immortal objects~~gh-84436 Add integration C API tests for immortal objectsApr 29, 2023

corona10 force-pushed the gh-84436-objects branch from 5b3447a to a3df017Compare May 2, 2023 03:38

erlend-aasland reviewed May 2, 2023
View reviewed changes

Comment threadModules/_testcapi/immortal.c Outdated

corona10and others added 13 commits May 2, 2023 19:13

pythongh-84436Add intergration C API tests for immortal objects
644e883

Update PCbuild/_testcapi.vcxproj
2eea452

Windows format
1c70211

Add immortal.c
6a83bae

Add test_immortal.py
94ca054

fix format
73daa12

make patchcheck
e5b8e45

fix format
2f4ee5f

address code review
55a394b

Adjust small int range
4fb6719

Address code review
e737489

nit
b03def1

Address code review
e0295b5

corona10 force-pushed the gh-84436-objects branch from a3df017 to e0295b5Compare May 2, 2023 10:14

Refactor test codes and fix test_immortal.py
5538ed4

corona10 requested a review from erlend-aasland May 2, 2023 10:22

corona10 merged commit d81ca7e into python:mainMay 2, 2023

bedevere-bot removed the awaiting core review label May 2, 2023

corona10 deleted the gh-84436-objects branch May 2, 2023 21:59

skirpichev mentioned this pull request Mar 13, 2026
gh-143050: correct PyLong_FromString() to use _PyLong_Negate() #145901
Merged

Navigation Menu

Uh oh!

Uh oh!

gh-84436 Add integration C API tests for immortal objects - #103962

gh-84436 Add integration C API tests for immortal objects#103962
corona10 merged 14 commits into
python:mainfrom
corona10:gh-84436-objects

corona10 commented Apr 28, 2023•
edited by bedevere-bot
Loading

Uh oh!

Uh oh!

erlend-aasland left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erlend-aasland left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

corona10 commented Apr 30, 2023

Uh oh!

Uh oh!

corona10 commented May 2, 2023•
edited
Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

corona10 commented Apr 28, 2023• edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

erlend-aasland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erlend-aasland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

corona10 commented Apr 30, 2023

Uh oh!

Uh oh!

corona10 commented May 2, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

corona10 commented Apr 28, 2023•
edited by bedevere-bot
Loading

corona10 commented May 2, 2023•
edited
Loading