GH-104308: socket.getnameinfo should release the GIL by njsmith · Pull Request #104307 · python/cpython

njsmith · 2023-05-08T20:49:31Z

I have no idea how we all missed this :-) Thanks to @brandyn for the report at python-trio/trio#1249 (comment)

Fixes#104308

ghost · 2023-05-08T20:49:58Z

All commit authors signed the Contributor License Agreement.

miss-islington · 2023-05-08T23:27:24Z

Thanks @njsmith for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

bedevere-bot · 2023-05-08T23:27:33Z

GH-104313 is a backport of this pull request to the 3.11 branch.

…104307) * socket.getnameinfo should release the GIL * 📜🤖 Added by blurb_it. --------- (cherry picked from commit faf1962) Co-authored-by: Nathaniel J. Smith <njs@pobox.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>

… (#104313) GH-104308: socket.getnameinfo should release the GIL (GH-104307) * socket.getnameinfo should release the GIL * 📜🤖 Added by blurb_it. --------- (cherry picked from commit faf1962) Co-authored-by: Nathaniel J. Smith <njs@pobox.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>

bedevere-bot · 2023-05-09T00:18:43Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x has failed when building commit faf1962.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/345/builds/4721) and take a look at the build logs.
Check if the failure is related to this commit (faf1962) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/345/builds/4721

Failed tests:

test__xxsubinterpreters
test_signal

Summary of the results of the build (if available):

==

Click to see traceback logs

remote: Enumerating objects: 16, done. remote: Counting objects: 6% (1/16) remote: Counting objects: 12% (2/16) remote: Counting objects: 18% (3/16) remote: Counting objects: 25% (4/16) remote: Counting objects: 31% (5/16) remote: Counting objects: 37% (6/16) remote: Counting objects: 43% (7/16) remote: Counting objects: 50% (8/16) remote: Counting objects: 56% (9/16) remote: Counting objects: 62% (10/16) remote: Counting objects: 68% (11/16) remote: Counting objects: 75% (12/16) remote: Counting objects: 81% (13/16) remote: Counting objects: 87% (14/16) remote: Counting objects: 93% (15/16) remote: Counting objects: 100% (16/16) remote: Counting objects: 100% (16/16), done. remote: Compressing objects: 12% (1/8) remote: Compressing objects: 25% (2/8) remote: Compressing objects: 37% (3/8) remote: Compressing objects: 50% (4/8) remote: Compressing objects: 62% (5/8) remote: Compressing objects: 75% (6/8) remote: Compressing objects: 87% (7/8) remote: Compressing objects: 100% (8/8) remote: Compressing objects: 100% (8/8), done. remote: Total 9 (delta 7), reused 2 (delta 1), pack-reused 0 
From https://github.com/python/cpython
* branch main -> FETCH_HEAD
Note: switching to 'faf196213e60d8a90773e9e5680d3252bd294643'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:
git switch -c <new-branch-name>
Or undo this operation with:
git switch -
Turn off this advice by setting config variable advice.detachedHead to false
HEAD is now at faf196213e GH-104308: socket.getnameinfo should release the GIL (#104307)
Switched to and reset branch 'main'
configure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly.
Fatal Python error: drop_gil: PyMUTEX_LOCK(gil->switch_mutex) failed
Python runtime state: initialized
Thread 0x00007fe072989280 (most recent call first):
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/runner.py", line 74 in _write_status
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/runner.py", line 95 in addSuccess
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/testresult.py", line 122 in addSuccess
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/case.py", line 648 in run
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/case.py", line 690 in __call__
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/runner.py", line 240 in run
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 1106 in _run_suite
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 1232 in run_unittest
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 294 in _test_module
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 330 in _runtest_inner2
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 373 in _runtest_inner
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 248 in _runtest
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 278 in runtest
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 365 in rerun_failed_tests
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 783 in _main
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 738 in main
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 802 in main
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/__main__.py", line 2 in <module>
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/runpy.py", line 88 in _run_code
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/runpy.py", line 198 in _run_module_as_main
Fatal Python error: Aborted
Thread 0x00007fe072989280 (most recent call first):
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/runner.py", line 74 in _write_status
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/runner.py", line 95 in addSuccess
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/testresult.py", line 122 in addSuccess
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/case.py", line 648 in run
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/case.py", line 690 in __call__
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/runner.py", line 240 in run
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 1106 in _run_suite
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 1232 in run_unittest
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 294 in _test_module
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 330 in _runtest_inner2
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 373 in _runtest_inner
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 248 in _runtest
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 278 in runtest
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 365 in rerun_failed_tests
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 783 in _main
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 738 in main
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 802 in main
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/__main__.py", line 2 in <module>
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/runpy.py", line 88 in _run_code
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/runpy.py", line 198 in _run_module_as_main
Extension modules: _testcapi, _xxsubinterpreters (total: 2)
Aborted
make: *** [Makefile:1956: buildbottest] Error 134
Cannot open file '/root/buildarea/3.x.angelico-debian-amd64/build/test-results.xml' for upload

bedevere-bot · 2023-05-09T01:38:33Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Arch Linux TraceRefs 3.x has failed when building commit faf1962.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/484/builds/3261) and take a look at the build logs.
Check if the failure is related to this commit (faf1962) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/484/builds/3261

Failed tests:

test__xxsubinterpreters

Summary of the results of the build (if available):

==

Click to see traceback logs

Note: switching to 'faf196213e60d8a90773e9e5680d3252bd294643'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:
git switch -c <new-branch-name>
Or undo this operation with:
git switch -
Turn off this advice by setting config variable advice.detachedHead to false
HEAD is now at faf196213e GH-104308: socket.getnameinfo should release the GIL (#104307)
Switched to and reset branch 'main'
Objects/object.c:2204: _Py_ForgetReference: Assertion failed: invalid object chain
Enable tracemalloc to get the memory block allocation traceback
object address : 0x7f6ef9f23c40
object refcount : 0
object type : 0x56033b4c8360
object type name: str
object repr : <refcnt 0 at 0x7f6ef9f23c40>
Fatal Python error: _PyObject_AssertFailed: _PyObject_AssertFailed
Python runtime state: initialized
Current thread 0x00007f6f0bc8e740 (most recent call first):
<no Python frame>
Debug memory block at address p=0x7f6f0bc05c80: API '�'
18302063728033398269bytes originally requested
The 7 pad bytes at p-7 are notall FORBIDDENBYTE (0xfd):
at p-7: 0xdd***OUCH
at p-6: 0xdd***OUCH
at p-5: 0xdd***OUCH
at p-4: 0xdd***OUCH
at p-3: 0xdd***OUCH
at p-2: 0xdd***OUCH
at p-1: 0xdd***OUCH
Because memory is corrupted at the start, the count of bytes requested
may be bogus, and checking the trailing pad bytes may segfault.
The 8 pad bytes at tail=0xfdfe7d6d09be5a7d are Fatal Python error: Segmentation fault
Current thread 0x00007f6f0bc8e740 (most recent call first):
<no Python frame>
Extension modules: _testcapi, _xxsubinterpreters (total: 2)
make: *** [Makefile:1962: buildbottest] Segmentation fault (core dumped)
Cannot open file '/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/test-results.xml' for upload

* main: (47 commits) pythongh-97696 Remove unnecessary check for eager_start kwarg (python#104188) pythonGH-104308: socket.getnameinfo should release the GIL (python#104307) pythongh-104310: Add importlib.util.allowing_all_extensions() (pythongh-104311) pythongh-99113: A Per-Interpreter GIL! (pythongh-104210) pythonGH-104284: Fix documentation gettext build (python#104296) pythongh-89550: Buffer GzipFile.write to reduce execution time by ~15% (python#101251) pythongh-104223: Fix issues with inheriting from buffer classes (python#104227) pythongh-99108: fix typo in Modules/Setup (python#104293) pythonGH-104145: Use fully-qualified cross reference types for the bisect module (python#104172) pythongh-103193: Improve `getattr_static` test coverage (python#104286) Trim trailing whitespace and test on CI (python#104275) pythongh-102500: Remove mention of bytes shorthand (python#104281) pythongh-97696: Improve and fix documentation for asyncio eager tasks (python#104256) pythongh-99108: Replace SHA3 implementation HACL* version (python#103597) pythongh-104273: Remove redundant len() calls in argparse function (python#104274) pythongh-64660: Don't hardcode Argument Clinic return converter result variable name (python#104200) pythongh-104265 Disallow instantiation of `_csv.Reader` and `_csv.Writer` (python#104266) pythonGH-102613: Improve performance of `pathlib.Path.rglob()` (pythonGH-104244) pythongh-103650: Fix perf maps address format (python#103651) pythonGH-89812: Churn `pathlib.Path` methods (pythonGH-104243) ...

Eclips4 · 2023-05-09T08:14:10Z

cc @ericsnowcurrently
Please, take a look at buildbots failure. Maybe it related to #104208 ?
Looks like that the same test is falling

ericsnowcurrently · 2023-05-09T15:19:14Z

@Eclips4, I'm not sure I see the relationship between these failures and gh-104208. Please elaborate.

Eclips4 · 2023-05-09T16:34:47Z

@Eclips4, I'm not sure I see the relationship between these failures and gh-104208. Please elaborate.

Output from first buildbot

test_create_thread (test.test__xxsubinterpreters.RunStringTests.test_create_thread) ... okFatalPythonerror: drop_gil: PyMUTEX_LOCK(gil->switch_mutex) failedPythonruntimestate: initializedThread0x00007fe072989280 (mostrecentcallfirst):
File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/runner.py", line74in_write_statusFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/runner.py", line95inaddSuccessFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/testresult.py", line122inaddSuccessFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/case.py", line648inrunFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/case.py", line690in__call__File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line122inrunFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line84in__call__File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line122inrunFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line84in__call__File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line122inrunFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line84in__call__File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/runner.py", line240inrunFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line1106in_run_suiteFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line1232inrun_unittestFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line294in_test_moduleFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line330in_runtest_inner2File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line373in_runtest_innerFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line248in_runtestFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line278inruntestFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line365inrerun_failed_testsFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line783in_mainFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line738inmainFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line802inmainFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/__main__.py", line2in<module>File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/runpy.py", line88in_run_codeFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/runpy.py", line198in_run_module_as_mainFatalPythonerror: AbortedThread0x00007fe072989280 (mostrecentcallfirst):
File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/runner.py", line74in_write_statusFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/runner.py", line95inaddSuccessFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/testresult.py", line122inaddSuccessFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/case.py", line648inrunFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/case.py", line690in__call__File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line122inrunFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line84in__call__File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line122inrunFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line84in__call__File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line122inrunFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line84in__call__File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/runner.py", line240inrunFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line1106in_run_suiteFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line1232inrun_unittestFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line294in_test_moduleFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line330in_runtest_inner2File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line373in_runtest_innerFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line248in_runtestFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line278inruntestFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line365inrerun_failed_testsFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line783in_mainFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line738inmainFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line802inmainFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/__main__.py", line2in<module>File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/runpy.py", line88in_run_codeFile"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/runpy.py", line198in_run_module_as_mainExtensionmodules: _testcapi, _xxsubinterpreters (total: 2)
Abortedmake: *** [Makefile:1956: buildbottest] Error134

* main: (29 commits) pythongh-104276: Make `_struct.unpack_iterator` type use type flag instead of custom constructor (python#104277) pythongh-97696: Move around and update the whatsnew entry for asyncio eager task factory (python#104298) pythongh-103193: Fix refleaks in `test_inspect` and `test_typing` (python#104320) require-pr-label.yml: Add missing "permissions:" (python#104309) pythongh-90656: Add platform triplets for 64-bit LoongArch (LA64) (python#30939) pythongh-104180: Read SOCKS proxies from macOS System Configuration (python#104181) pythongh-97696 Remove unnecessary check for eager_start kwarg (python#104188) pythonGH-104308: socket.getnameinfo should release the GIL (python#104307) pythongh-104310: Add importlib.util.allowing_all_extensions() (pythongh-104311) pythongh-99113: A Per-Interpreter GIL! (pythongh-104210) pythonGH-104284: Fix documentation gettext build (python#104296) pythongh-89550: Buffer GzipFile.write to reduce execution time by ~15% (python#101251) pythongh-104223: Fix issues with inheriting from buffer classes (python#104227) pythongh-99108: fix typo in Modules/Setup (python#104293) pythonGH-104145: Use fully-qualified cross reference types for the bisect module (python#104172) pythongh-103193: Improve `getattr_static` test coverage (python#104286) Trim trailing whitespace and test on CI (python#104275) pythongh-102500: Remove mention of bytes shorthand (python#104281) pythongh-97696: Improve and fix documentation for asyncio eager tasks (python#104256) pythongh-99108: Replace SHA3 implementation HACL* version (python#103597) ...

* main: (156 commits) pythongh-97696 Add documentation for get_coro() behavior with eager tasks (python#104304) pythongh-97933: (PEP 709) inline list/dict/set comprehensions (python#101441) pythongh-99889: Fix directory traversal security flaw in uu.decode() (python#104096) pythongh-104184: fix building --with-pydebug --enable-pystats (python#104217) pythongh-104139: Add itms-services to uses_netloc urllib.parse. (python#104312) pythongh-104240: return code unit metadata from codegen (python#104300) pythongh-104276: Make `_struct.unpack_iterator` type use type flag instead of custom constructor (python#104277) pythongh-97696: Move around and update the whatsnew entry for asyncio eager task factory (python#104298) pythongh-103193: Fix refleaks in `test_inspect` and `test_typing` (python#104320) require-pr-label.yml: Add missing "permissions:" (python#104309) pythongh-90656: Add platform triplets for 64-bit LoongArch (LA64) (python#30939) pythongh-104180: Read SOCKS proxies from macOS System Configuration (python#104181) pythongh-97696 Remove unnecessary check for eager_start kwarg (python#104188) pythonGH-104308: socket.getnameinfo should release the GIL (python#104307) pythongh-104310: Add importlib.util.allowing_all_extensions() (pythongh-104311) pythongh-99113: A Per-Interpreter GIL! (pythongh-104210) pythonGH-104284: Fix documentation gettext build (python#104296) pythongh-89550: Buffer GzipFile.write to reduce execution time by ~15% (python#101251) pythongh-104223: Fix issues with inheriting from buffer classes (python#104227) pythongh-99108: fix typo in Modules/Setup (python#104293) ...

* main: (35 commits) pythongh-97696 Add documentation for get_coro() behavior with eager tasks (python#104304) pythongh-97933: (PEP 709) inline list/dict/set comprehensions (python#101441) pythongh-99889: Fix directory traversal security flaw in uu.decode() (python#104096) pythongh-104184: fix building --with-pydebug --enable-pystats (python#104217) pythongh-104139: Add itms-services to uses_netloc urllib.parse. (python#104312) pythongh-104240: return code unit metadata from codegen (python#104300) pythongh-104276: Make `_struct.unpack_iterator` type use type flag instead of custom constructor (python#104277) pythongh-97696: Move around and update the whatsnew entry for asyncio eager task factory (python#104298) pythongh-103193: Fix refleaks in `test_inspect` and `test_typing` (python#104320) require-pr-label.yml: Add missing "permissions:" (python#104309) pythongh-90656: Add platform triplets for 64-bit LoongArch (LA64) (python#30939) pythongh-104180: Read SOCKS proxies from macOS System Configuration (python#104181) pythongh-97696 Remove unnecessary check for eager_start kwarg (python#104188) pythonGH-104308: socket.getnameinfo should release the GIL (python#104307) pythongh-104310: Add importlib.util.allowing_all_extensions() (pythongh-104311) pythongh-99113: A Per-Interpreter GIL! (pythongh-104210) pythonGH-104284: Fix documentation gettext build (python#104296) pythongh-89550: Buffer GzipFile.write to reduce execution time by ~15% (python#101251) pythongh-104223: Fix issues with inheriting from buffer classes (python#104227) pythongh-99108: fix typo in Modules/Setup (python#104293) ...

ericsnowcurrently · 2023-05-09T17:44:35Z

thanks

ericsnowcurrently · 2023-05-09T22:26:58Z

I've created gh-104341.

bedevere-bot added the awaiting core review label May 8, 2023

njsmith changed the title ~~socket.getnameinfo should release the GIL~~GH-104307: socket.getnameinfo should release the GILMay 8, 2023

socket.getnameinfo should release the GIL
01a232b

njsmith force-pushed the socket-getnameinfo-release-gil branch from f4a8cc7 to 01a232bCompare May 8, 2023 20:52

📜🤖 Added by blurb_it.
a91f5fb

njsmith mentioned this pull request May 8, 2023
socket.getnameinfo doesn't drop the GIL #104308
Closed

njsmith changed the title ~~GH-104307: socket.getnameinfo should release the GIL~~GH-104308: socket.getnameinfo should release the GILMay 8, 2023

njsmith added the needs backport to 3.11 only security fixes label May 8, 2023

JelleZijlstra approved these changes May 8, 2023
View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels May 8, 2023

njsmith merged commit faf1962 into python:mainMay 8, 2023

bedevere-bot removed the awaiting merge label May 8, 2023

njsmith deleted the socket-getnameinfo-release-gil branch May 8, 2023 23:27

bedevere-bot removed the needs backport to 3.11 only security fixes label May 8, 2023

ericsnowcurrently mentioned this pull request May 9, 2023
test__xxsubinterpreters is Occasionally Crashing #104341
Closed

Navigation Menu

Uh oh!

Uh oh!

GH-104308: socket.getnameinfo should release the GIL - #104307

GH-104308: socket.getnameinfo should release the GIL#104307
njsmith merged 2 commits into
python:mainfrom
njsmith:socket-getnameinfo-release-gil

njsmith commented May 8, 2023•
edited
Loading

Uh oh!

ghost commented May 8, 2023•
edited by ghost
Loading

Uh oh!

miss-islington commented May 8, 2023

Uh oh!

bedevere-bot commented May 8, 2023

Uh oh!

bedevere-bot commented May 9, 2023

Uh oh!

bedevere-bot commented May 9, 2023

Uh oh!

Eclips4 commented May 9, 2023

Uh oh!

ericsnowcurrently commented May 9, 2023

Uh oh!

Eclips4 commented May 9, 2023

Uh oh!

ericsnowcurrently commented May 9, 2023

Uh oh!

ericsnowcurrently commented May 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

njsmith commented May 8, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented May 8, 2023• edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miss-islington commented May 8, 2023

Uh oh!

bedevere-bot commented May 8, 2023

Uh oh!

bedevere-bot commented May 9, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented May 9, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Eclips4 commented May 9, 2023

Uh oh!

ericsnowcurrently commented May 9, 2023

Uh oh!

Eclips4 commented May 9, 2023

Uh oh!

ericsnowcurrently commented May 9, 2023

Uh oh!

ericsnowcurrently commented May 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

njsmith commented May 8, 2023•
edited
Loading

ghost commented May 8, 2023•
edited by ghost
Loading