Uh oh!
There was an error while loading. Please reload this page.
gh-74895: adjust tests to work on Solaris - #104326
Merged
Merged
Conversation
kulikjak
commented
May 9, 2023
ContributorAuthor
@gpshead (as you recently merged the original change) |
miss-islington
commented
May 9, 2023
Contributor
miss-islington
commented
May 9, 2023
Contributor
Sorry, @kulikjak and @gpshead, I could not cleanly backport this to |
kulikjak
commented
May 10, 2023
ContributorAuthor
Thank you! |
carljm added a commit
to carljm/cpython
that referenced
this pull request
May 10, 2023
* main: pythonGH-102181: Improve specialization stats for SEND (pythonGH-102182) pythongh-103000: Optimise `dataclasses.asdict` for the common case (python#104364) pythongh-103538: Remove unused TK_AQUA code (pythonGH-103539) pythonGH-87695: Fix OSError from `pathlib.Path.glob()` (pythonGH-104292) pythongh-104263: Rely on Py_NAN and introduce Py_INFINITY (pythonGH-104202) pythongh-104010: Separate and improve docs for `typing.get_origin` and `typing.get_args` (python#104013) pythongh-101819: Adapt _io._BufferedIOBase_Type methods to Argument Clinic (python#104355) pythongh-103960: Dark mode: invert image brightness (python#103983) pythongh-104252: Immortalize Py_EMPTY_KEYS (pythongh-104253) pythongh-101819: Clean up _io windows console io after pythongh-104197 (python#104354) pythongh-101819: Harden _io init (python#104352) pythongh-103247: clear the module cache in a test in test_importlib/extensions/test_loader.py (pythonGH-104226) pythongh-103848: Adds checks to ensure that bracketed hosts found by urlsplit are of IPv6 or IPvFuture format (python#103849) pythongh-74895: adjust tests to work on Solaris (python#104326) pythongh-101819: Refactor _io in preparation for module isolation (python#104334) pythongh-90953: Don't use deprecated AST nodes in clinic.py (python#104322) pythongh-102327: Extend docs for "url" and "headers" parameters to HTTPConnection.request() pythongh-104328: Fix typo in ``typing.Generic`` multiple inheritance error message (python#104335)
miss-islington
commented
May 11, 2023
Contributor
miss-islington
commented
May 11, 2023
Contributor
Sorry, @kulikjak and @gpshead, I could not cleanly backport this to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adjusts tests introduced in #2435 such that they work on platforms where
socket.getaddrinfo(None, port)doesn't end with success; however, it does so whensocket.SOCK_STREAMis present.I am aware only of Solaris that works this way, but it's still well within the standard (if not "more correct").
All other tests calling
getaddrinfo(None, ....)includesocket.SOCK_STREAMas well, and the addition doesn't change at all the thing the test is testing, so hopefully, this is acceptable.(can I reuse the original issue for an additional commit?)