Skip to content

gh-104360: remove reference to removed module-level wrap_socket - #104361

Merged
encukou merged 3 commits into
python:mainfrom
graingert:remove-wrap-socket-ref
Jan 24, 2024
Merged

gh-104360: remove reference to removed module-level wrap_socket#104361
encukou merged 3 commits into
python:mainfrom
graingert:remove-wrap-socket-ref

Conversation

@graingert

@graingertgraingert commented May 10, 2023

Copy link
Copy Markdown
Contributor

Comment threadDoc/library/ssl.rst Outdated
@graingert
graingert marked this pull request as ready for review May 10, 2023 14:57
Comment threadDoc/library/ssl.rst
:exc:`SSLWantReadError` if it needs more data than the incoming BIO has
available.

- There is no module-level ``wrap_bio()`` call like there is for

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ssl.wrap_context() is removed, but ssl.SSLContext.wrap_socket does not.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eamanu right but there is no module-level wrap_socket so this section doesn't make sense anymore

@graingert
graingert requested a review from eamanuJune 2, 2023 09:57
@graingert
graingert requested a review from tiranNovember 1, 2023 18:49

@AA-TurnerAA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The substantive documentation was removed in #99023.

A

@AA-TurnerAA-Turner added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jan 12, 2024
@encukou
encukou merged commit 127a497 into python:mainJan 24, 2024
@miss-islington-app

Copy link
Copy Markdown

Thanks @graingert for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 24, 2024
…pythonGH-104361)
* remove reference to removed module-level wrap_socket
* drive by typo fix
(cherry picked from commit 127a497)
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 24, 2024
…pythonGH-104361)
* remove reference to removed module-level wrap_socket
* drive by typo fix
(cherry picked from commit 127a497)
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
@bedevere-app

Copy link
Copy Markdown

GH-114528 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Jan 24, 2024
@bedevere-app

Copy link
Copy Markdown

GH-114529 is a backport of this pull request to the 3.11 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.11 only security fixes label Jan 24, 2024
encukou pushed a commit that referenced this pull request Jan 24, 2024
GH-104361) (GH-114528)
* remove reference to removed module-level wrap_socket
* drive by typo fix
(cherry picked from commit 127a497)
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…pythonGH-104361)
* remove reference to removed module-level wrap_socket
* drive by typo fix
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…pythonGH-104361)
* remove reference to removed module-level wrap_socket
* drive by typo fix
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@graingert@eamanu@AA-Turner@encukou@bedevere-bot